Skip to content

Dead-code cleanup: consolidate #213–#221 - #224

Merged
CuriosityOS merged 9 commits into
mainfrom
dead-code-cleanup
Sep 21, 2026
Merged

CuriosityOS merged 9 commits into
mainfrom
dead-code-cleanup

Conversation

@CuriosityOS

Copy link
Copy Markdown
Collaborator

What and why

Consolidates nine dead-code-scan PRs into one branch so they can land in a single CI round (branch protection requires each PR to be up to date with main, which made merging them one at a time impractical). Each original commit is cherry-picked unchanged:

No user-visible behaviour change. The originals will be closed once this merges.

Checklist

  • bun run lint, bun run typecheck, bun run check:build, bun run build:harness, bun run test:types pass locally. bun run test:unit: 1294 pass, 1 fail (custom endpoint validation, pre-existing on main, environment-dependent).
  • Guard proxy — unrelated.
  • Secret redaction — unrelated.
  • Dependency pins — untouched.
  • Public API — types/challenges.d.ts loses only declarations that were never reachable via types/index.d.ts; bun run test:types passes.
  • CI job names unchanged; no new actions.
  • No test imports src/worker.ts.
  • No CHANGELOG entry: no user-visible change.
  • Nothing private committed.

CuriosityOS and others added 9 commits September 21, 2026 18:02
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

Safe to merge: the reviewed cleanup preserves the exercised local AI lock recovery behavior.

What we checked:

  • Executed the stale-legacy-file-lock repro script to exercise the legacy file lock path and validate the contract. T-Rex
  • Inspected the complete observed output to verify the run results, including that the callback ran and the expected withLocalLock value appeared in the log. T-Rex
  • Confirmed the run exited with code 0 and did not report any failures or timeouts. T-Rex

Summary

  • Removes unused research utilities, internal helpers, obsolete compatibility code, and related tests.
  • Keeps the supported package entrypoints and public challenge-detection declaration surface intact.
  • Confirms local AI setup can still recover an aged legacy file lock and continue installation work.

No merge-blocking issues were found.

Reviews (1) · Last reviewed commit: "Remove test-only chromiumForkAssetForHos..."

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Starting E2E review of BetterWright/betterwright PR #224 (head 40974d2): verifying PR state, checking prior coverage, then building and running the PR.

@CuriosityOS CuriosityOS mentioned this pull request Sep 21, 2026
9 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant