Skip to content

Remove orphaned scripts/bench-runtime.ts - #215

Closed
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789965540-remove-bench-runtime
Closed

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789965540-remove-bench-runtime

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

scripts/bench-runtime.ts (node-vs-bun CLI startup timer from the Bun 1.4 migration) has no invoker — no package.json script, workflow, shell script, or doc references it; its only mention is the files entry in tsconfig.tools.json. Deleted the file and that entry. BENCH_ITERS was read only there.

Checklist

  • bun run release:check passes locally — ran typecheck, check:build, lint instead (all green); the rest is unaffected by removing a type-check-only script.
  • Guard proxy invariant — unrelated (no runtime code touched).
  • Secrets/redaction — unrelated.
  • Dependency pins — unrelated.
  • Public API / types/*.d.ts — unrelated.
  • CI job names / SHA pins — unchanged.
  • No unit test imports src/worker.ts — unchanged.
  • CHANGELOG/docs — no user-visible behaviour change.
  • Nothing private committed.

How it was verified

bun run typecheck, bun run check:build, bun run lint on Bun 1.4.0.

Link to Devin session: https://app.devin.ai/sessions/0d0d624ea6294bd0bff7be5d933bcb3c
Open in Devin Desktop: https://app.devin.ai/desktop/session/0d0d624ea6294bd0bff7be5d933bcb3c?variant=devin
Requested by: @CuriosityOS

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the deleted utility has no remaining callers or documented workflow dependencies.

Summary

This PR removes an orphaned CLI startup benchmarking script and its corresponding entry from the tooling TypeScript configuration.

  • Deletes scripts/bench-runtime.ts.
  • Removes the deleted file from tsconfig.tools.json.
  • Leaves current build, release, CI, and documented benchmark workflows unchanged.

Reviews (1) · Last reviewed commit: "Remove orphaned scripts/bench-runtime.ts"

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Starting E2E review of BetterWright/betterwright PR #215 (head 6140b65); checking PR state and prior coverage first.

@CuriosityOS

Copy link
Copy Markdown
Collaborator

Landed on main via #224 (consolidated dead-code cleanup).

@CuriosityOS
CuriosityOS deleted the devin/1789965540-remove-bench-runtime branch September 21, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant