Repository navigation
Remove dead pixePuzzleNavigationUrl helper - #217
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Contributor
Author
9 tasks done
Collaborator
|
Landed on main via #224 (consolidated dead-code cleanup). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
pixePuzzleNavigationUrlinsrc/site-tools.tslost its only production caller whensrc/worker.tsdropped it in 9b2e040 (1.8.0); since then it has been kept alive solely by its own unit test. This deletes the function, its import, and the test block intests/node/site-tools.test.ts.site-tools.tsis not part of the packageexportsortypes/, so no public surface changes. Code-scan findingsfind-57fad9842ff14da683b24ca48e1c6ad7.Checklist
bun run lint,bun run typecheck,bun run build,bun run test:unitpass locally. Fullrelease:checknot run; the twochromium-package.test.tsfailures seen locally are pre-existing onmain(this box's Python lackshashlib.file_digest) and unrelated.site-tools.tsis internal;types/*.d.tsunaffected.src/worker.ts.How it was verified
bun run lint,bun run typecheck,bun run build,bun run test:unit(1270 pass; the 2 failures reproduce identically onmainwith the change stashed).rg pixePuzzleNavigationUrl|pixe\.frgmtnow returns nothing in the repo.Link to Devin session: https://app.devin.ai/sessions/a6b7f7b5ead84feabe17ad53353eaa90
Open in Devin Desktop: https://app.devin.ai/desktop/session/a6b7f7b5ead84feabe17ad53353eaa90?variant=devin
Requested by: @CuriosityOS