Skip to content

Remove dead pixePuzzleNavigationUrl helper - #217

Closed
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789965554-remove-pixe-puzzle-url
Closed

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789965554-remove-pixe-puzzle-url

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

pixePuzzleNavigationUrl in src/site-tools.ts lost its only production caller when src/worker.ts dropped it in 9b2e040 (1.8.0); since then it has been kept alive solely by its own unit test. This deletes the function, its import, and the test block in tests/node/site-tools.test.ts. site-tools.ts is not part of the package exports or types/, so no public surface changes. Code-scan finding sfind-57fad9842ff14da683b24ca48e1c6ad7.

Checklist

  • bun run lint, bun run typecheck, bun run build, bun run test:unit pass locally. Full release:check not run; the two chromium-package.test.ts failures seen locally are pre-existing on main (this box's Python lacks hashlib.file_digest) and unrelated.
  • Guard proxy invariant — unrelated, no browser/transport code touched.
  • Secret redaction — unrelated, no output channels touched.
  • Dependency pins — unrelated, no version changes.
  • Public API — site-tools.ts is internal; types/*.d.ts unaffected.
  • CI job names unchanged, no workflow changes.
  • No unit test imports src/worker.ts.
  • No user-visible behaviour change; no CHANGELOG/docs entry needed.
  • Nothing private committed.

How it was verified

bun run lint, bun run typecheck, bun run build, bun run test:unit (1270 pass; the 2 failures reproduce identically on main with the change stashed). rg pixePuzzleNavigationUrl|pixe\.frgmt now returns nothing in the repo.

Link to Devin session: https://app.devin.ai/sessions/a6b7f7b5ead84feabe17ad53353eaa90
Open in Devin Desktop: https://app.devin.ai/desktop/session/a6b7f7b5ead84feabe17ad53353eaa90?variant=devin
Requested by: @CuriosityOS

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the removed helper has no remaining callers or supported public exposure.

Summary

Removes the unused, internal pixePuzzleNavigationUrl helper and its dedicated unit test.

  • No remaining code references the helper or its Pixe-specific routing behavior.
  • Package exports and declarations do not expose the removed symbol as public API.
  • Existing site-tool consumers import only the remaining helpers.

Reviews (1) · Last reviewed commit: "Remove dead pixePuzzleNavigationUrl help..."

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Starting E2E review of BetterWright/betterwright PR #217 (head e8a7b99); checking PR state and dedup first.

@CuriosityOS

Copy link
Copy Markdown
Collaborator

Landed on main via #224 (consolidated dead-code cleanup).

@CuriosityOS
CuriosityOS deleted the devin/1789965554-remove-pixe-puzzle-url branch September 21, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant