Skip to content

Remove unused staleAgentSkillTip helper - #218

Closed
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789965572-remove-stale-skill-tip
Closed

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789965572-remove-stale-skill-tip

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

staleAgentSkillTip in src/skill-install.ts had no runtime callers — only tests/node/skill-install.test.ts referenced it. Delete it and the tip assertions in that test. staleAgentSkillReport (used by src/doctor.ts) is untouched. Remediates code-scan finding sfind-cbdf2c60dc1a4e068142a166aa00b335.

Checklist

  • bun run release:check passes locally — ran bun run lint, bun run typecheck, bun run build, bun run test:unit instead (see below).
  • Guard proxy invariant — unrelated (no browser/transport changes).
  • No secret value reaches the model sandbox — unrelated (no output channels touched).
  • Dependency pins — unrelated (no version changes).
  • Public API changes update types/*.d.ts — staleAgentSkillTip is not declared in types/; nothing to update.
  • CI job names unchanged; no new actions.
  • No unit test imports src/worker.ts.
  • CHANGELOG.md/docs — no user-visible behaviour change.
  • Nothing private committed.

How it was verified

bun run lint, bun run typecheck, bun run build, bun test tests/node/skill-install.test.ts (12 pass). Full bun run test:unit: 1271 pass, 2 fail in tests/node/chromium-package.test.ts (native archive tests) — those fail identically on the unmodified tree in this Linux environment and are unrelated.

Link to Devin session: https://app.devin.ai/sessions/bf23b3ddb0254bb2b8902ba1719d40ba
Open in Devin Desktop: https://app.devin.ai/desktop/session/bf23b3ddb0254bb2b8902ba1719d40ba?variant=devin
Requested by: @CuriosityOS

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Starting E2E review of BetterWright/betterwright PR #218 (head 8cf5da4); checking PR state and dedup first.

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because it removes only an unused internal helper and its test-only coverage.

Summary

This PR removes the unused internal staleAgentSkillTip formatting helper and its corresponding test-only assertions while preserving staleAgentSkillReport and the doctor command’s stale-skill warning behavior.

  • Removes an unreferenced helper from src/skill-install.ts.
  • Removes its sole import and assertions from the skill installation tests.
  • Does not alter the public package API or active runtime behavior.

Reviews (1) · Last reviewed commit: "Remove unused staleAgentSkillTip helper"

@CuriosityOS

Copy link
Copy Markdown
Collaborator

Landed on main via #224 (consolidated dead-code cleanup).

@CuriosityOS
CuriosityOS deleted the devin/1789965572-remove-stale-skill-tip branch September 21, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant