Skip to content

Remove unreferenced isPopulatedObjectExpression lint helper - #213

Closed
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789965514-remove-is-populated-object-expression
Closed

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789965514-remove-is-populated-object-expression

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

Deletes isPopulatedObjectExpression from tools/oxlint/anti-slop/shared/dictionary-types.ts. It has no importers repo-wide (only its own declaration) and is a narrower near-duplicate of the adjacent isKnownEvidenceExpression, which no-known-value-widening uses instead. Removing it avoids drift between two almost-identical predicates. Dead-code scan finding sfind-89ba9196eef845eea2312f626ac13348.

Checklist

  • bun run release:check passes locally — not run; only build:tools and lint are affected by this change and both pass (see below).
  • Locally launched browsers and Electron attachments stay on the guard proxy. Unrelated: repo-local lint tooling only.
  • No secret value reaches the model sandbox. Unrelated: no runtime code touched.
  • Dependency pins are still mirrored everywhere. Unrelated: no dependency changes.
  • Public API changes update types/*.d.ts in this same commit. Unrelated: tools/ is not part of the published package.
  • The two branch-protected CI job names are unchanged; no workflow changes.
  • No unit test imports src/worker.ts or dist/src/worker.js directly — no test changes.
  • User-visible behaviour is reflected in CHANGELOG.md — unrelated: no user-visible change.
  • Nothing private is being committed.

How it was verified

  • rg isPopulatedObjectExpression across the repo returns only the declaration.
  • bun run build:tools (tsc on tsconfig.tools.json) passes.
  • bun run lint (loads the oxlint anti-slop plugin) passes with the same pre-existing warnings as before.

Link to Devin session: https://app.devin.ai/sessions/0ebc04688b57475c9c149da4150c081f
Open in Devin Desktop: https://app.devin.ai/desktop/session/0ebc04688b57475c9c149da4150c081f?variant=devin
Requested by: @CuriosityOS

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because it only removes an unreferenced lint helper.

Summary

Removes the unused isPopulatedObjectExpression export from the shared anti-slop lint utilities, eliminating dead code that overlaps with the retained evidence-expression predicate.

  • No callers or imports remain.
  • No runtime, dependency, workflow, or public package behavior changes.

Reviews (1) · Last reviewed commit: "Remove unreferenced isPopulatedObjectExp..."

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Starting E2E review of BetterWright/betterwright PR #213 (head f342640); checking PR state and dedup first.

CuriosityOS added a commit that referenced this pull request Sep 21, 2026
* Remove unreferenced isPopulatedObjectExpression helper

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove orphaned research probes (pixelscan, creepjs, headless-tells)

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove orphaned scripts/bench-runtime.ts

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* types: trim challenges.d.ts to the public detectBotChallenge surface

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove dead pixePuzzleNavigationUrl helper and its test

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove unused staleAgentSkillTip helper

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* live-view: drop dead pre-Node-18.4 numeric address-family compat

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove obsolete legacy file-lock reclaim branch from withLocalLock

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove test-only chromiumForkAssetForHost helper

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@CuriosityOS

Copy link
Copy Markdown
Collaborator

Landed on main via #224 (consolidated dead-code cleanup).

@CuriosityOS
CuriosityOS deleted the devin/1789965514-remove-is-populated-object-expression branch September 21, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant