Repository navigation
Remove test-only chromiumForkAssetForHost helper - #221
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
|
9 tasks done
CuriosityOS
added a commit
that referenced
this pull request
Sep 21, 2026
* Remove unreferenced isPopulatedObjectExpression helper Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * Remove orphaned research probes (pixelscan, creepjs, headless-tells) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * Remove orphaned scripts/bench-runtime.ts Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * types: trim challenges.d.ts to the public detectBotChallenge surface Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * Remove dead pixePuzzleNavigationUrl helper and its test Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * Remove unused staleAgentSkillTip helper Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * live-view: drop dead pre-Node-18.4 numeric address-family compat Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * Remove obsolete legacy file-lock reclaim branch from withLocalLock Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * Remove test-only chromiumForkAssetForHost helper Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Collaborator
|
Landed on main via #224 (consolidated dead-code cleanup). |
CuriosityOS
deleted the
devin/1789965644-remove-chromium-fork-asset-for-host
branch
September 21, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Dead-code scan finding:
chromiumForkAssetForHostinsrc/chromium-fork-install.tswas a one-line wrapper overCHROMIUM_FORK_ASSETS[platformKey(...)]with no production callers (installChromiumForkdoes its own lookup) and notypes/declaration or package export. Its only consumer was three assertions intests/node/chromium-fork-install.test.tsthat compared it againstCHROMIUM_FORK_ASSETS[...], which the same test already asserts in full viadeepEqual. Removed the helper, its import, and the redundant assertions.platformKeyand theCHROMIUM_FORK_ASSETSimport stay (still used byinstallChromiumFork).Checklist
bun run lint,bun run typecheck,bun run build:harness, andtests/node/chromium-fork-install.test.tspass locally. Fullrelease:checknot run (Linux box, not the macOS blueprint);test:unithas two preexistingnative win/linux archivefailures onmainthat are unrelated.types/*.d.ts, so no declaration change.worker.How it was verified
bun run lint,bun run typecheck,bun run build && bun run build:harness,bun test tests/node/chromium-fork-install.test.ts(25 pass). Repo-wide grep forchromiumForkAssetForHostreturns no hits outsidedist/.Link to Devin session: https://app.devin.ai/sessions/650ae2fe731f40fab23c2cab12dd17b4
Open in Devin Desktop: https://app.devin.ai/desktop/session/650ae2fe731f40fab23c2cab12dd17b4?variant=devin
Requested by: @CuriosityOS