Skip to content

Remove test-only chromiumForkAssetForHost helper - #221

Closed
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789965644-remove-chromium-fork-asset-for-host
Closed

devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1789965644-remove-chromium-fork-asset-for-host

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

Dead-code scan finding: chromiumForkAssetForHost in src/chromium-fork-install.ts was a one-line wrapper over CHROMIUM_FORK_ASSETS[platformKey(...)] with no production callers (installChromiumFork does its own lookup) and no types/ declaration or package export. Its only consumer was three assertions in tests/node/chromium-fork-install.test.ts that compared it against CHROMIUM_FORK_ASSETS[...], which the same test already asserts in full via deepEqual. Removed the helper, its import, and the redundant assertions. platformKey and the CHROMIUM_FORK_ASSETS import stay (still used by installChromiumFork).

Checklist

  • bun run lint, bun run typecheck, bun run build:harness, and tests/node/chromium-fork-install.test.ts pass locally. Full release:check not run (Linux box, not the macOS blueprint); test:unit has two preexisting native win/linux archive failures on main that are unrelated.
  • Guard proxy — unrelated (no launch/transport changes).
  • Secrets — unrelated (no output channels touched).
  • Dependency pins — unrelated.
  • Public API — the helper was never declared in types/*.d.ts, so no declaration change.
  • CI job names unchanged; no new actions.
  • No test imports worker.
  • No user-visible behaviour change; CHANGELOG untouched.
  • Nothing private committed.

How it was verified

bun run lint, bun run typecheck, bun run build && bun run build:harness, bun test tests/node/chromium-fork-install.test.ts (25 pass). Repo-wide grep for chromiumForkAssetForHost returns no hits outside dist/.

Link to Devin session: https://app.devin.ai/sessions/650ae2fe731f40fab23c2cab12dd17b4
Open in Devin Desktop: https://app.devin.ai/desktop/session/650ae2fe731f40fab23c2cab12dd17b4?variant=devin
Requested by: @CuriosityOS

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

Starting E2E review of BetterWright/betterwright PR #221 (head ff613f8); checking PR state and dedup first.

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because it removes unused test-only code without changing production behavior or a supported API.

Summary

Removes the test-only chromiumForkAssetForHost wrapper and its redundant assertions.

  • Production asset selection remains unchanged in installChromiumFork.
  • The comprehensive CHROMIUM_FORK_ASSETS assertion remains in place.
  • No supported public API or internal caller depends on the removed helper.

Reviews (1) · Last reviewed commit: "Remove test-only chromiumForkAssetForHos..."

CuriosityOS added a commit that referenced this pull request Sep 21, 2026
* Remove unreferenced isPopulatedObjectExpression helper

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove orphaned research probes (pixelscan, creepjs, headless-tells)

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove orphaned scripts/bench-runtime.ts

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* types: trim challenges.d.ts to the public detectBotChallenge surface

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove dead pixePuzzleNavigationUrl helper and its test

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove unused staleAgentSkillTip helper

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* live-view: drop dead pre-Node-18.4 numeric address-family compat

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove obsolete legacy file-lock reclaim branch from withLocalLock

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* Remove test-only chromiumForkAssetForHost helper

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@CuriosityOS

Copy link
Copy Markdown
Collaborator

Landed on main via #224 (consolidated dead-code cleanup).

@CuriosityOS
CuriosityOS deleted the devin/1789965644-remove-chromium-fork-asset-for-host branch September 21, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant