Repository navigation
Add settings panel to toggle UWP review alert beeps - #17
Closed
serrebidev wants to merge 1 commit into
Closed
serrebidev wants to merge 1 commit into
serrebidev wants to merge 1 commit into
Conversation
Reviewing a UWP window iterates its element tree, which can take a moment, so the command plays a beep before and after as progress feedback. Some users find the beeps unwanted. Add a Virtual Revision panel to NVDA's settings with a checkbox to turn them off (on by default, preserving the current behaviour). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Author
|
This PR is the optional settings panel — a toggle for the UWP review alert beeps.
Notes for review:
|
|
Ported to ragb#6, where maintenance now continues. Credited via Co-Authored-By. Thanks @serrebidev. |
Author
|
Ported with credit and merged in the maintained repository as ragb#6. Closing this obsolete PR in the old repository. |
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Virtual Revision category to NVDA's settings dialog with a single checkbox: "Play alert beeps when reviewing UWP windows" (enabled by default).
Why
When reviewing a UWP window, the command walks the element tree, which can take a moment, so it plays a beep before and after as progress feedback. That feedback is helpful for some users and unwanted for others. This makes it configurable without changing the default behaviour.
Details
config.conf.spec["virtualRevision"]withplayBeep(defaultTrue).VirtualRevisionSettingsPanelin__init__/terminate(skipped on secure screens).No change for existing users unless they turn the beeps off.
🤖 Generated with Claude Code