Skip to content

Add settings panel to toggle UWP review alert beeps - #17

Closed
serrebidev wants to merge 1 commit into
ruifontes:masterfrom
serrebidev:settings-beep-toggle
Closed

serrebidev wants to merge 1 commit into
ruifontes:masterfrom
serrebidev:settings-beep-toggle

Conversation

@serrebidev

Copy link
Copy Markdown

What

Adds a Virtual Revision category to NVDA's settings dialog with a single checkbox: "Play alert beeps when reviewing UWP windows" (enabled by default).

Why

When reviewing a UWP window, the command walks the element tree, which can take a moment, so it plays a beep before and after as progress feedback. That feedback is helpful for some users and unwanted for others. This makes it configurable without changing the default behaviour.

Details

  • Registers config.conf.spec["virtualRevision"] with playBeep (default True).
  • Registers/unregisters VirtualRevisionSettingsPanel in __init__/terminate (skipped on secure screens).
  • The pre/post beeps in the UWP branch now honour the setting.

No change for existing users unless they turn the beeps off.

🤖 Generated with Claude Code

Reviewing a UWP window iterates its element tree, which can take a moment,
so the command plays a beep before and after as progress feedback. Some
users find the beeps unwanted. Add a Virtual Revision panel to NVDA's
settings with a checkbox to turn them off (on by default, preserving the
current behaviour).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@serrebidev

Copy link
Copy Markdown
Author

This PR is the optional settings panel — a toggle for the UWP review alert beeps.
Part of a three-PR set that splits a batch of Windows Terminal / command-line review improvements into independent, single-purpose changes. Each is branched off master and touches only addon/globalPlugins/virtualRevision.py, so they can be reviewed and merged in any order (or accepted/rejected independently):

Notes for review:

  • They edit the same file, so whichever merges first will leave the others needing a trivial rebase — happy to do that on request.
  • I deliberately left the addon_version / addon_changelog bump in buildVars.py out: it's date-based and yours to set at release, and three parallel branches would otherwise all conflict on that one line. Tell me the version you'd like and I'll add the changelog entry.
  • Verified on NVDA 2026.1 / Windows 11 (Windows Terminal running cmd, PowerShell and WSL, plus a legacy conhost console).

@ragb

ragb commented Aug 24, 2026

Copy link
Copy Markdown

Ported to ragb#6, where maintenance now continues. Credited via Co-Authored-By. Thanks @serrebidev.

@serrebidev

Copy link
Copy Markdown
Author

Ported with credit and merged in the maintained repository as ragb#6. Closing this obsolete PR in the old repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants