Repository navigation
Add setting to disable the alert beeps for UWP review - #14
Closed
serrebidev wants to merge 1 commit into
Closed
serrebidev wants to merge 1 commit into
serrebidev wants to merge 1 commit into
Conversation
The virtual review script plays a 400 Hz beep before and after walking the UIA tree of a UWP foreground window, to signal that the (potentially slow) operation is in progress. Some users find the beep intrusive, especially on faster machines where the walk completes near-instantly. Add a "Play alert beeps when reviewing UWP windows" checkbox under a new "Virtual Revision" category in NVDA's Settings dialog. Default is on, so existing behavior is preserved; users who don't want the beep can turn it off without losing the actual review functionality. Settings panel is only registered when not running on a secure screen, to match the existing GlobalPlugin disablement pattern at the bottom of the file.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The virtual review script plays a 400 Hz beep before and after walking the UIA tree of a UWP foreground window (
script_virtualWindowReview, lines around theWindows.UI.Core/Windows.UI.Input.InputSitebranch). The beep was added to signal that a potentially slow operation is in progress, but some users — especially on faster machines where the walk completes near-instantly — find the double-beep on every NVDA+Ctrl+W press intrusive.This adds a new "Virtual Revision" category to NVDA's Settings dialog with a single "Play alert beeps when reviewing UWP windows" checkbox. Default is on, so existing behavior is preserved; users who don't want the beep can turn it off without losing the actual review functionality.
Changes
config.conf.spec[\"virtualRevision\"]with a singleplayBeepboolean (defaultTrue).VirtualRevisionSettingsPanel(settingsDialogs.SettingsPanel).GlobalPlugin.__init__registers the panel;terminate()removes it. Registration is gated onnot globalVars.appArgs.secureto match the existing secure-screen handling at the bottom of the file.tones.beep(...)calls are wrapped in anif playBeep:check;import tonesis only performed when the beep is actually going to play.Test plan
🤖 Generated with Claude Code