Repository navigation
Port UWP beep toggle setting from upstream (serrebidev) - #6
Merged
Merged
Conversation
Reviewing a UWP window walks the element tree, which can take a moment, so a beep plays before and after as progress feedback. On faster machines the walk finishes near-instantly and the double beep on every press is just noise. Adds a Virtual Revision category to NVDA's settings with a checkbox to turn it off; the default is unchanged. Ported from ruifontes#17. Co-Authored-By: serrebidev <serrebi101@gmail.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports @serrebidev's ruifontes#17 from the old repo. Credited via
Co-Authored-By.Reviewing a UWP window walks the element tree, so a beep plays before and after as progress feedback. On faster machines the walk is near-instant and the double beep on every
control+NVDA+wis just noise. Adds a Virtual Revision category to NVDA's settings with a single checkbox; default behaviour is unchanged.Applied on top of the terminal fixes from #5, so the beep branch keeps the
elifthose introduced.One thing worth a look before merge:
terminate()removes the panel fromcategoryClassesbut does not callsuper().terminate(). That is how the upstream PR is written and I kept it faithful, but it may be worth adding.ruff checkandruff formatpass; builds withscons. Not yet exercised in a running NVDA.