Honor pack-freshness sample limit instead of hardcoding 10k - #8
Closed
Pitchfork-and-Torch wants to merge 2 commits into
Closed
Pitchfork-and-Torch wants to merge 2 commits into
Pitchfork-and-Torch wants to merge 2 commits into
Conversation
…sim, power Wh calibration, soak protocols, partner tabletop, not a complete archive, not free commercial broadband.
_pack_freshness accepted limit=50 but always walked until 10_000 dirs, then still claimed the caller's limit in sample_limit_note. Cap the scan at limit and keep the note accurate.
Pitchfork-and-Torch
force-pushed
the
main
branch
from
September 18, 2026 02:03
99965f6 to
6ce014a
Compare
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_pack_freshness(..., limit=50)ignoredlimitand always scanned until 10_000 package dirs, whilesample_limit_notestill claimed the caller’s limit.limit(and treatlimit < 1as empty) so local ops snapshots stay cheap and the note matches reality.--record, Keep disaster-drill render inside the repo by default #6 disaster-drill render, Start empty when the DTN queue file is corrupt #7 DTN corrupt queue.Test plan
pytest tests/test_pack_freshness_limit.py(2 passed)