fix: honor handoff export --limit 0 - #9
Closed
Pitchfork-and-Torch wants to merge 2 commits into
Closed
Pitchfork-and-Torch wants to merge 2 commits into
Pitchfork-and-Torch wants to merge 2 commits into
Conversation
…sim, power Wh calibration, soak protocols, partner tabletop, not a complete archive, not free commercial broadband.
export_phone_handoff used max(1, limit), so limit=0 still selected one package. Cap at max(0, limit) so an empty dry export stays empty.
Pitchfork-and-Torch
force-pushed
the
main
branch
from
September 18, 2026 02:28
6ce014a to
dc4ef1b
Compare
Pitchfork-and-Torch
deleted the
cook/handoff-export-honor-zero-limit
branch
September 18, 2026 02:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
export_phone_handoffselected packages with[: max(1, int(limit))], so--limit 0still exported one package.Fix
Use
max(0, int(limit))so an empty dry export stays empty.Test
pytest tests/test_handoff_export_limit.py -qDistinct from prior cooks #5–#8 (integrity --record / disaster-drill path / DTN corrupt / pack-freshness limit).