fix: honor rx field-log --limit 0 - #11
Closed
Pitchfork-and-Torch wants to merge 2 commits into
Closed
Pitchfork-and-Torch wants to merge 2 commits into
Pitchfork-and-Torch wants to merge 2 commits into
Conversation
…t, custody, USB mule v2, mesh hop-forward sim, not Starlink, not RFC 9171, not free commercial broadband.
list_field_log used max(1, limit), so --limit 0 still returned one row. Match gateway receipts / handoff export: limit<=0 means empty.
Pitchfork-and-Torch
force-pushed
the
main
branch
from
September 18, 2026 02:49
11c45a5 to
51720bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
list_field_log(..., limit=0)usedlines[-max(1, limit):], soskycache rx log --list --limit 0still returned one row.Distinct from prior cooks: ≠ #5 integrity --record, #6 disaster-drill render, #7 DTN corrupt queue, #8 pack-freshness sample limit, #9 handoff export --limit 0, #10 gateway receipts --limit 0.
Fix
Treat
limit <= 0as an empty list (same pattern as gateway receipts / handoff export).Test
python3 -m pytest tests/test_rx_field_log_limit.py -q