Fix rendered crawl startup, document capture, and CI fixtures - #487
Open
PrzemyslawKlys wants to merge 10 commits into
Open
PrzemyslawKlys wants to merge 10 commits into
PrzemyslawKlys wants to merge 10 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2-speedygonzales #487 +/- ##
=====================================================
+ Coverage 58.05% 58.08% +0.03%
=====================================================
Files 486 487 +1
Lines 36054 36021 -33
Branches 7249 7252 +3
=====================================================
- Hits 20930 20923 -7
+ Misses 12757 12734 -23
+ Partials 2367 2364 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PrzemyslawKlys
force-pushed
the
fix/crawl-document-capture
branch
from
October 5, 2026 22:01
abd51a0 to
c0213f7
Compare
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered crawls prepare their browser session before the first navigation, so request routes and initialization scripts apply to the destination. Capture HTML, title, URL and document identity together after interactions, and retry a replaced execution context within the existing capture deadline. A committed non-HTTP destination is skipped without carrying over the previous response metadata. Public session navigation and configured form login retain their existing behavior.
The HTTP and browser fixtures now wait for complete request headers and observe when a stalled read has started before testing cancellation. Unknown-length response-limit checks use a generated stream, and the PowerShell fixtures use syntax supported by Windows PowerShell's C# compiler. The script recipe fixture gives its script step the tested 100 ms limit while page navigation uses the normal deadline. This includes the fixture fixes from #494 and #496 so CI can exercise them with the browser correction.
Validation: all 1,573 tests pass in the full .NET 10 suite. The HTTP, structure and split-packet header cases pass on .NET 10, .NET 8 and .NET Framework 4.7.2. All 25 public crawl cases, both public routing/login-isolation cases and three recipe timeout/navigation/error cases pass in PowerShell 5.1 and 7.