Skip to content

Create crawler sessions before navigating to a destination - #484

Closed
PrzemyslawKlys wants to merge 1 commit into
v2-speedygonzalesfrom
fix/crawl-render-startup
Closed

PrzemyslawKlys wants to merge 1 commit into
v2-speedygonzalesfrom
fix/crawl-render-startup

Conversation

@PrzemyslawKlys

@PrzemyslawKlys PrzemyslawKlys commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

The startup correction is included in #487, which validates crawler session creation and final-document capture together. That PR carries the replacement for this duplicate.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T12:44:03.000977Z c947ea3 PR opened
🔒 Security Review ✅ Completed 2026-10-05T12:47:40.749609Z c947ea3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.19%. Comparing base (fc94c5b) to head (64620cb).

Files with missing lines Patch % Lines
Sources/HtmlTinkerX/HtmlCrawler.Browser.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           v2-speedygonzales     #484      +/-   ##
=====================================================
+ Coverage              58.05%   58.19%   +0.14%     
=====================================================
  Files                    484      484              
  Lines                  36046    36048       +2     
  Branches                7254     7255       +1     
=====================================================
+ Hits                   20925    20979      +54     
+ Misses                 12752    12696      -56     
- Partials                2369     2373       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PrzemyslawKlys PrzemyslawKlys changed the title Prepare rendered crawls without waiting for an idle blank page Create crawler sessions before navigating to a destination Oct 5, 2026
@PrzemyslawKlys
PrzemyslawKlys force-pushed the fix/crawl-render-startup branch from c947ea3 to 64620cb Compare October 5, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant