Correct HTTP response-limit and cancellation test fixtures - #496
Closed
PrzemyslawKlys wants to merge 3 commits into
Closed
PrzemyslawKlys wants to merge 3 commits into
PrzemyslawKlys wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2-speedygonzales #496 +/- ##
=====================================================
- Coverage 58.13% 58.12% -0.02%
=====================================================
Files 484 486 +2
Lines 36063 36054 -9
Branches 7256 7249 -7
=====================================================
- Hits 20964 20955 -9
Misses 12726 12726
Partials 2373 2373 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixture changes are included in #487. Closing this duplicate so the browser correction and its test fixtures can be reviewed together.
The stalled-response checks finish without waiting for the test runner's synchronization context. Timeout and caller cancellation remain separate cases for each HTTP consumer, with the existing deadlines, watchdogs, exception assertions and response-disposal checks.
The response-limit fixtures distinguish declared and unknown-length bodies. The latter use a non-seekable stream and verify that
Content-Lengthis absent. The declared-size cases exercise the default limit without allocating four unused 16 MiB bodies.The public crawl fixture also runs in Windows PowerShell 5.1: its embedded server uses supported C# syntax, and relative-link expectations use URI APIs available in both runtimes.
Validation: 39 focused checks passed on .NET 10 and .NET 8, and 35 on .NET Framework 4.7.2. All 25 public crawl Pester cases passed in PowerShell 5.1 and 7. The last full local .NET 10 run passed 1,545 cases and failed one Firefox navigation case; browser startup and document capture are addressed separately in #487. Current PR CI remains a merge gate.