Repository navigation
Read complete HTTP headers in browser test fixtures - #494
Closed
PrzemyslawKlys wants to merge 2 commits into
Closed
PrzemyslawKlys wants to merge 2 commits into
PrzemyslawKlys wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2-speedygonzales #494 +/- ##
=====================================================
- Coverage 58.13% 58.12% -0.01%
=====================================================
Files 484 484
Lines 36063 36063
Branches 7256 7256
=====================================================
- Hits 20964 20963 -1
Misses 12726 12726
- Partials 2373 2374 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixture changes are included in #487. Closing this duplicate so the browser correction and its test fixtures can be reviewed together.
The browser test servers could reply after reading only the first TCP packet. A scoped header split across packets was then recorded as absent, weakening the header-isolation assertions.
Read complete headers in the existing TCP fixtures, share the bounded reader with the CORS fixture, and close pending reads when a fixture is disposed. Two regressions send headers in separate writes and verify that the server waits for the complete header. The focused checks live beside the shared fixture helper.
The final Linux PDF/browser class passes all 201 tests. The two fragmented-header regressions, redirect header-isolation checks and source-structure gate pass on each Windows .NET target. The browser security assertions remain unchanged.