Repository navigation
feat!: rename sw-cli tool to builtin - #1627
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe built-in verifier is now named ChangesBuilt-in checker naming
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The legacy name remains accepted, and selecting both names runs the built-in checker once. No concrete merge risk remains. Security Architecture ReviewSecurity architecture risk: ⚪ Minimal · up to The rename preserves selection and exclusion through the legacy name without granting additional authority or bypassing checker-selection controls. Report consumers may need to adopt the new name, but no material security risk was identified in the changed behavior. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 5.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 10 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1627 +/- ##
==========================================
- Coverage 65.72% 65.72% -0.01%
==========================================
Files 462 462
Lines 30928 30940 +12
==========================================
+ Hits 20327 20334 +7
- Misses 10601 10606 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
998e05b to
01af12f
Compare
BREAKING CHANGE: sw-cli as input is still accepted but emits a deprecation warning now. Output only shows builtin as invoked tool now.
Co-authored-by: Anne <a.hintzpeter@shopware.com>
b1f2448 to
4d5b34a
Compare
Reflects shopware/shopware-cli#1627, which renamed the built-in extension validation checker from 'sw-cli' to 'builtin'. The old name remains accepted as a legacy alias for --only/--exclude but now emits a deprecation warning.
|
Warning Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding. What happenedThe threat detection engine failed to produce results. Review the workflow run logs for details. This PR renames the built-in extension validation checker from Draft PR in cc Malte Janz (@MalteJanz) for review. |
What changed?
sw-clitobuiltin.sw-cliaccepted as a backwards-compatible alias for--onlyand--exclude.sw-cliis used as input:builtinconsistently in reports, statuses, errors, help text, and documentation.Why?
Built on top of #1618 , addressing the comment there:
#1618 (comment)
The name
sw-clidescribes the binary rather than the purpose of the verifier.builtinmakes it clear that this tool contains the checks built into Shopware CLI.Existing CI configurations and scripts using
--only sw-clicontinue to work, while the warning guides users toward the new canonical name.How was this tested?
sw-cliinput handling for--onlyand--excludeBackwards compatibility
The following remains supported:
Summary by CodeRabbit
builtinin validation commands and reports.sw-cliremains accepted when selecting or excluding the checker, but now triggers a deprecation warning.sw-cliremains a legacy alias.