Repository navigation
fix: keep release validation on the built-in checks - #201
Merged
Merged
Conversation
shopware/shopware-cli#1618 makes extension validate run all checkers by default. build-zip and store-release install the latest CLI and call extension validate without flags, so release runs would pick up the new default and fail before the store upload. Pass --only sw-cli, which is what these steps run today and which the current 0.18.5 release already accepts.
Lena Forlin (moshimorschi)
marked this pull request as ready for review
September 28, 2026 12:20
Lena Forlin (moshimorschi)
requested review from
a team,
Anne (Ant1gua),
Malte Janz (MalteJanz),
somethings (lasomethingsomething),
Soner (shyim) and
Tomasz Turkowski (tturkowski)
and removed request for
a team
September 28, 2026 12:25
Soner (shyim)
approved these changes
Sep 28, 2026
Lena Forlin (moshimorschi)
force-pushed
the
fix/release-actions-builtin-validation
branch
2 times, most recently
from
September 28, 2026 13:13
2439453 to
4d5d419
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
extension validatein the build-zip and store-release actions (and the reusable workflows of the same names) now passes--only sw-cli, which is exactly the set of checks these steps run today.Why?
shopware/shopware-cli#1618 makes
extension validaterun all checkers (PHPStan, ESLint, Stylelint, Twig linters) by default. These actions install the latest CLI and callextension validatewithout flags, so every release run through them would pick up the new default and fail on the first finding, before the store upload. Tried the new default on SwagPayPal, SwagCmsExtensions, SwagLanguagePack and SwagMigrationAssistant: all four fail.The flag already works on the current 0.18.5 release with identical findings and exit code, so this can be merged before the CLI ships the change.
Not touched: extension-verifier keeps
--fulluntil the minimum CLI has the new default, since removing it earlier would drop the code checks on older versions. A per-extension opt-in for the full checks at release time can follow once the repos are green.