Repository navigation
fix: tighten extension anonymize rules after QA - #1657
Soner (shyim) merged 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A broken extension config now stops project dump --anonymize instead of silently skipping that extension. Built-in rules win over extension rules, JSON_REMOVE rules on the same column are combined, faker values inside JSON are escaped, and text around a faker template in dump.rewrite works again. Unknown keys under anonymize are an error, and the schema requires key in system_config objects. The skill validates with --only builtin and covers relocated configs, sandbox mode, JSON, free-text and unique columns.
62dd33c to
d36a8c4
Compare
44e4924
into
cursor/extension-anonymize-dump-70b3
What changed?
These are the fixes from the QA of #1635. They're one PR into your branch, so you can take what you like.
--anonymizesilently skipped that extension, and its secrets stayed in the dump.customer.email: email.JSON_REMOVErules on the same column are combined. With Mollie and PayPal installed, PayPal's data inorder_transaction.custom_fieldsstayed in the dump.faker.Address.Address()broke the import.dump.rewriteworks again (qa+{{- faker.Internet.User() -}}@example.com), and faker inside SQL still works.anonymizeis an error, and the schema requireskeyinsystem_configobjects.--only builtin, handles configs the build copies into place, sets sandbox or test mode, and covers JSON, free-text and unique columns. The README section no longer splits the environments text.One heads-up:
--only builtinneeds #1627 from main, so it works once main is merged into your branch.How was this tested?
Unit tests for each fix. End to end on MariaDB 11.8, including a restore and a storefront check, and the JSON case also on MySQL 8.4. Agents re-ran the skill on three real extensions.
Related issue or discussion
#1635, #1315