Repository navigation
Fix Apple AI requests and refresh chat-capable model choices - #2754
Open
AlexSchmidt1999 wants to merge 1 commit into
Open
AlexSchmidt1999 wants to merge 1 commit into
AlexSchmidt1999 wants to merge 1 commit into
Conversation
AlexSchmidt1999
marked this pull request as ready for review
October 10, 2026 12:47
This was referenced Oct 10, 2026
Author
|
I am using NOOP 12.1.0 Release build 456 on my iPhone 17 Pro Max, and the app runs very smoothly in everyday use. This PR is included in that combined build, together with my other Apple changes and the performance fixes from #2724 by @UtkuDenizAltiok and #2705 by @kavemang. The installed source is d67cceb5. Both Apple builds and the local app, analytics, database and Python test suites passed for this combined build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
GPT-5 and o-series requests start with parameters those models reject. Both OpenAI reply paths now send
max_completion_tokensdirectly. Classic GPT sampling and Gemini's existing temperature stay unchanged. Custom servers keep the legacy-first retry.The model picker adds GPT-5.4/5.4-mini and current Claude choices, removes retired Claude 3 entries, and excludes families this Chat Completions client cannot use. Anthropic and Gemini model refreshes handle pagination. Gemini reuses the existing image-capable streaming path. Anthropic joins visible text blocks, and provider errors inside successful SSE responses reach the caller.
This updates the Apple clients. Android is unchanged. The parameter change follows OpenAI's Chat Completions reference. The removed Claude models are listed as retired in Anthropic's lifecycle table.
Type of change
How it was tested
URLProtocol fixtures cover request bodies, model parsing, pagination, retries, and streaming errors. No paid provider requests or health data were sent.
At
6be600c79c4f, the local macOS build and focused StrandTests passed. The iOS Release build, source hygiene, and diff-scoped Apple translation checks passed too. These are local results, separate from GitHub checks.Checklist
GitHub validation was rechecked on October 11 at
6be600c79c4f. All 5 registered checks passed, including the macOS app build and tests and the iOS app build.