Repository navigation
Fix AI provider requests and follow the app language - #8
Closed
AlexSchmidt1999 wants to merge 2 commits into
Closed
AlexSchmidt1999 wants to merge 2 commits into
AlexSchmidt1999 wants to merge 2 commits into
Conversation
Owner
Author
|
Closing this older fork test PR. Its full head ( The relevant changes are now submitted for upstream review in #2754, #2755. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI Chat Completions requests now use
max_completion_tokens; GPT-5 and o-series requests omit unsupported temperature values. GPT-5.4 and GPT-5.4-mini are available without changing the selected/default model or removing existing choices.Apple coach prompts follow the app language. Gemini model pagination and existing temperature/output limits are retained; Anthropic text blocks, custom-provider fallback and streaming error handling are corrected. This change is Apple-only; Android sources are unchanged.
Validation: 32 focused Apple AI tests passed initially and again on the combined training branch. macOS and iOS app builds passed. Live requests with personal API keys were not used.
Fork testing first. No upstream PR is requested yet.