Repository navigation
Simplify Gemini streaming and training activity ownership - #15
Closed
AlexSchmidt1999 wants to merge 3 commits into
Closed
AlexSchmidt1999 wants to merge 3 commits into
AlexSchmidt1999 wants to merge 3 commits into
Conversation
Owner
Author
|
Closing this older fork test PR. Its full head ( The relevant changes are now submitted for upstream review in #2754, #2761. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemini's text-only stream duplicated the existing optional-image streaming request. It now delegates to that path with
inlineImage: nil, preserving the request body, sampling value, authentication, error handling and SSE output. The iOS app also drops its unused Lift activity state handle, since TrainingCoordinator already retains that controller, and removes an unread training snapshot label.These three audit cleanups remove 25 net source lines and keep the existing features and settings. The Gemini and training changes are separate commits. This fork-only draft is stacked on #14; build 441 combines the existing test version with the cleanups.
Validation:
Live Gemini calls and physical training/Live Activity behavior were not rerun for this refactor. No upstream PR or release was created.