Skip to content

Simplify Gemini streaming and training activity ownership - #15

Closed
AlexSchmidt1999 wants to merge 3 commits into
codex/training-widget-configurefrom
codex/audit-feature-cleanup
Closed

AlexSchmidt1999 wants to merge 3 commits into
codex/training-widget-configurefrom
codex/audit-feature-cleanup

Conversation

@AlexSchmidt1999

Copy link
Copy Markdown
Owner

Gemini's text-only stream duplicated the existing optional-image streaming request. It now delegates to that path with inlineImage: nil, preserving the request body, sampling value, authentication, error handling and SSE output. The iOS app also drops its unused Lift activity state handle, since TrainingCoordinator already retains that controller, and removes an unread training snapshot label.

These three audit cleanups remove 25 net source lines and keep the existing features and settings. The Gemini and training changes are separate commits. This fork-only draft is stacked on #14; build 441 combines the existing test version with the cleanups.

Validation:

  • macOS app compiled; all 18 existing AI request/streaming and training snapshot tests passed, including Gemini streamed text parts and the preserved temperature/output cap.
  • iOS Release app, widget and watch targets compiled. Translation coverage and doc-comment hygiene passed.
  • Source and binary policy checks passed. Build-counter baseline review confirmed unchanged capability, dependency, executable and endpoint sets; the binary scan covered four bundles and four Mach-O files.
  • Build 441 was signed, installed and launched over Wi-Fi on the paired iPhone, retaining its existing bundle ID. The installed version and commit were verified locally.

Live Gemini calls and physical training/Live Activity behavior were not rerun for this refactor. No upstream PR or release was created.

@AlexSchmidt1999

Copy link
Copy Markdown
Owner Author

Closing this older fork test PR. Its full head (4a47aec5425b) is included in the combined test branch. New test-version work continues in #28. The branch and commits are kept.

The relevant changes are now submitted for upstream review in #2754, #2761.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants