adjusts indel CIGAR to better match bwa-meth - #70
Open
bwlang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the left alignment of indels when using the
--methmode. Previously, indels were not always left-aligned according to SAM and VCF conventions due to the way methylation-aware base comparisons were handled. The update introduces a new function to correctly determine when bases can be considered equivalent during left alignment, improving compatibility and accuracy.Bugfixes and Algorithm Improvements
mb_base_swap_okfunction to correctly determine if swapping two bases across an indel preserves alignment score, accounting for methylation-aware equivalence (e.g., C<->T and G<->A) (align.c).mb_fix_cigarto usemb_base_swap_ok, ensuring indels are shifted left as far as possible under methylation-aware scoring (align.c).mb_fix_cigarinmb_update_extrato pass the scoring matrix, enabling methylation-aware base comparison during left alignment (align.c).Documentation
NEWS.mddescribing the bug, the fix, and the impact on alignment accuracy and compatibility with bwa-meth (NEWS.md).