Skip to content

api/vk: handle clips without titles - #1580

Open
Rexarrior wants to merge 1 commit into
imputnet:mainfrom
Rexarrior:fix/vk-video-response-items
Open

api/vk: handle clips without titles#1580
Rexarrior wants to merge 1 commit into
imputnet:mainfrom
Rexarrior:fix/vk-video-response-items

Conversation

@Rexarrior

Copy link
Copy Markdown

VK's video.get currently returns title: null for some clips. This caused
video.title.trim() to throw, and the error was reported as
error.api.fetch.critical.

This falls back to the first line of the video description, or to a stable
vk_<owner>_<video> identifier when the description is empty.

I added regression cases using the links from both reported issues.
fixes #1557
fixes #1547
Tested with:

pnpm --filter @imput/cobalt-api test -- run-tests-for vk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vk clip doesnt downloading Can't download videos from vk.com on clip format

1 participant