Skip to content

api/vk: handle clips without titles #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rexarrior wants to merge 1 commit into
base: main
Choose a base branch
from
Open

api/vk: handle clips without titles #1580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions api/src/processing/services/vk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,11 @@ export default async function ({ ownerId, videoId, accessKey, quality, subtitleL

if (!url) return { error: "fetch.fail" };

const fileMetadata = {
title: video.title.trim(),
}
const title = video.title?.trim()
|| video.description?.trim().split(/\r?\n/, 1)[0]
|| `vk_${ownerId}_${videoId}`;

const fileMetadata = { title }

let subtitles;
if (subtitleLang && video.subtitles?.length) {
Expand Down
18 changes: 18 additions & 0 deletions api/src/util/tests/vk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,24 @@
"status": "tunnel"
}
},
{
"name": "clip without title",
"url": "https://vk.com/clip-227182972_456239182",
"params": {},
"expected": {
"code": 200,
"status": "tunnel"
}
},
{
"name": "clip without title or description",
"url": "https://vk.com/clip-219815090_456243369",
"params": {},
"expected": {
"code": 200,
"status": "tunnel"
}
},
{
"name": "video, defaults",
"url": "https://vk.com/video-57274055_456239399",
Expand Down