Fix glass block translucency: use CPU uniforms and auto-detect block.png layout

[ford442]

Problem

test.1ink.us/tetris-webgpu blocks looked much less translucent than go.1ink.us/tetris — not because of PHP, htaccess, or UTF-16 encoding.

Root causes

1. Shader ignored CPU glass tuning — fragmentMain.wgsl hardcoded glassMin=0.82 / glassMax=0.97 while viewMaterials.ts writes artist-tunable values (default ~0.30–0.78) into FragmentUniforms.reserved2. Glass centers stayed ~82–97% opaque, so the video portal barely showed through.

2. Different deployed assets — go.1ink.us serves a 768×768 block.png (~1 MB) loaded as a single tile. test.1ink.us serves the 2816×1536 atlas (~6.5 MB) with subregion extraction. Same Apache COOP/COEP headers on both hosts; PNGs are served as binary image/png.

3. Wrong crop if atlas coords used on a single tile — subregion defaults target the middle tile of the 2816 atlas. Applying them to a 768 image crops a corner sliver and breaks metal/glass mask baking.

Fix

• Read glassMin, glassMax, and Fresnel power from fUniforms.reserved2 in the authored sampling path.
• applyBlockTextureConfigForImageDimensions() picks atlas vs full-image crop based on image size before tile extraction.

Testing

• npm test — 213 passed

  

Summary by CodeRabbit

• New Features

  • Improved block texture handling for both large and small images, including automatic sizing and sampling adjustments.
  • Enhanced glass rendering with configurable opacity and Fresnel effects.

• Bug Fixes

  • Improved texture configuration selection based on the loaded image dimensions.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b67b1d08-d333-4b85-b801-b5a4a3814f91

📥 Commits

Reviewing files that changed from the base of the PR and between b6f1af0 and 8969ecc.

📒 Files selected for processing (3)

• src/webgpu/blockTexture.ts
• src/webgpu/shaders/wgsl/block/fragmentMain.wgsl
• src/webgpu/viewPipelines.ts

---

📝 Walkthrough

Walkthrough

The change adds image-dimension-based block texture configuration during image loading and updates authored glass opacity to use configurable Fresnel parameters from shader uniforms.

Changes

Block rendering updates

Layer / File(s)	Summary
Dimension-based texture configuration src/webgpu/blockTexture.ts, src/webgpu/viewPipelines.ts	Images at least 2000 pixels on their maximum dimension use the default atlas configuration. Smaller images use single-tile sampling, full-image bounds, warmth detection, and adjusted metal thresholds.
Configurable authored glass opacity src/webgpu/shaders/wgsl/block/fragmentMain.wgsl	The shader reads opacity bounds and Fresnel power from fUniforms.reserved2, clamps the power, and applies it to the edge Fresnel term.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• ford442/Tetris_WebGPU#292: Shares block-texture material detection and metal-threshold changes.
• ford442/Tetris_WebGPU#334: Shares block texture configuration and authored glass Fresnel handling.
• ford442/Tetris_WebGPU#379: Shares block-rendering Fresnel behavior changes.

Suggested reviewers: claude

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/fix-glass-translucency-9725

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}