Enhance image sampled blocks to be more translucent and glass-like - #471
Conversation
Lowered the `authoredGlassMin` and `authoredGlassMax` values in both `blockTexture.ts` and `materials.ts` to make the inner part of image sampled blocks more translucent, allowing the background to show through clearly. Additionally, updated the fragment shader (`fragmentMain.wgsl`) to simulate actual glass refraction on the `useAuthoredSampling` path, providing a high-quality glass effect similar to the PBR shader path. Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe change deletes the WGSL patch script, lowers authored glass opacity ranges, adds tinted environment refraction to the block shader, and updates the video manifest build timestamp. ChangesAuthored glass rendering
Asset metadata
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Improved the "JUICE" of the image sampled blocks by enhancing their glass-like visual properties.
authoredGlassMinfrom 0.30/0.38 to 0.15,authoredGlassMaxfrom 0.78 to 0.70).useAuthoredSamplingblock shader path to simulate realistic glass light bending.PR created automatically by Jules for task 8655165164921342192 started by @ford442
Summary by CodeRabbit
New Features
Improvements