Repository navigation
Conversation
This was referenced Sep 3, 2026
New stable clippy fails `cargo clippy --all-targets --all-features -- -Dwarnings` on main: * question_mark in actions::unlock (x2) * collapsible_match in api::classify_login_error * useless_borrows_in_formatting in dirs::runtime_dir * map_unwrap_or in commands::search * uninlined_format_args and borrow_as_ptr in rbw-agent::debugger (x3) No behavior change. MSRV stays 1.82: `&raw const` and `Result::is_ok_and` are both stable there.
m11y
force-pushed
the
fix/clippy-1.98
branch
from
September 3, 2026 08:30
ed096dc to
9c29fc7
Compare
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippy --all-targets --all-features -- -Dwarnings(the CI lint job) currently fails onmainwith stable clippy 1.98. CI reports four of them; the other four are hidden because the library fails to compile first.question_markinactions::unlock(x2),collapsible_matchinapi::classify_login_error,useless_borrows_in_formattingindirs::runtime_dir,map_unwrap_orincommands::search, anduninlined_format_args(x2) plusborrow_as_ptrinrbw-agent::debugger.The
collapsible_matchfix turns the""arm ofclassify_login_errorinto a guarded arm. Behavior is unchanged: when the guard is false the value falls through to the existing_ => {}, which is what the innerifalready did.MSRV stays at 1.82:
&raw constis stable in 1.82 andResult::is_ok_andin 1.70.CI note
With this branch the
lintjob now gets pastcargo clippyandcargo fmt --checkfor the first time, and then fails at its third step,cargo deny check, on RustSec advisories inCargo.lock(bytesinteger overflow, twoquick-xmlDoS advisories,randunsoundness, fourrustls-webpkiadvisories, and yankedspin). Those are independent of this change and need a dependency refresh, which seemed like your call rather than something to fold in here.Test plan
cargo clippy --all-targets --all-features -- -Dwarnings(clean; was 8 errors)cargo fmt --checkcargo test --all-features