Repository navigation
Conversation
This was referenced Sep 3, 2026
m11y
force-pushed
the
fix/cipher-write-safety
branch
from
September 3, 2026 06:48
bed1c18 to
341bf9f
Compare
Author
|
Hey @doy, hope you're doing well! I submitted this PR a while ago and just wanted to gently check in to see if you've had a chance to take a look. No rush at all - I know everyone has a lot on their plate! There are also 3 other open PRs that might be worth reviewing when you have time:
Happy to make any changes or clarifications if needed. Thanks so much for your time and for maintaining this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reprompt,favorite,archivedDate, andlastKnownRevisionDateon full cipher PUTs.actions::edit/Client::editlibrary entry points in favor ofedit_with_metaand adds fields todb::Entry, which is a documented Rust source break.Relationship to #368
This overlaps #368 by @Mic92, which was opened first and fixes the same item-key corruption more narrowly. The item-key approach here is the same one; this PR additionally preserves
reprompt/favorite/archivedDate, sendslastKnownRevisionDateso a stale full PUT cannot clobber a concurrent edit, fixes the agent's reprompt-set ordering, and reworks post-write exit semantics. Those additions are why it renamesedittoedit_with_metainstead of adding akeyparameter, so the two branches conflict textually.Either order works. If #368 merges first I will rebase onto it and drop the duplicated part; if this one is preferred, #368 can be closed.
Test plan
cargo test --all-featurescargo clippy --bin rbw --lib -- -D warningscargo fmt --checkCI's
lintjob is red here for reasons that predate this branch: stable clippy 1.98 fails--all-targets --all-features -- -Dwarningsonmainitself, at eight sites in code this PR does not touch. #373 fixes those. That job then fails again atcargo deny checkon RustSec advisories inCargo.lock(bytes,quick-xml,rand,rustls-webpki, yankedspin), which is also independent of this branch and needs a dependency refresh.cargo clippy --bin rbw --lib,cargo fmt --check, andcargo test --all-featuresare clean on this branch.Related: #364