Repository navigation
Conversation
2 of 8 tasks
m11y
force-pushed
the
feat/edit-custom-field-v2
branch
from
September 3, 2026 06:49
4ed66a3 to
d21dc8f
Compare
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rbw edit --field=<name>for updating one existing custom field on login, secure note, card, and identity entries from piped stdin or an interactive editor.rbw get --list-custom-fields, Fish completion, documentation, and focused tests for field lookup, help stripping, validation, and conflict comparison.This branch is stacked on #371. Until that PR merges, GitHub's base comparison also shows its safety changes; the feature-only change is commit
d21dc8fand touches five files.Test plan
cargo test --all-featurescargo clippy --bin rbw --lib -- -D warningscargo fmt --checkfish -n src/bin/rbw/completion/rbw.fishrbw edit --field=<existing> <entry>and verify it withrbw get --field=<existing>Depends on: #371
CI's
lintjob is red here for reasons that predate this branch: stable clippy 1.98 fails--all-targets --all-features -- -Dwarningsonmainitself, at eight sites in code this PR does not touch. #373 fixes those. That job then fails again atcargo deny checkon RustSec advisories inCargo.lock(bytes,quick-xml,rand,rustls-webpki, yankedspin), which is also independent of this branch and needs a dependency refresh.cargo clippy --bin rbw --lib,cargo fmt --check, andcargo test --all-featuresare clean on this branch.Related: #364