Repository navigation
feat(projects): add jenkins, microsoft teams, telegram integrations - #435
Open
henrysachs wants to merge 6 commits into
Open
henrysachs wants to merge 6 commits into
henrysachs wants to merge 6 commits into
Conversation
Signed-off-by: Henry Sachs <henry.sachs@deutschebahn.com>
This was referenced Oct 14, 2026
…ns, teams, telegram Signed-off-by: Henry Sachs <henry.sachs@deutschebahn.com>
GitLab answers a project_name with leading or trailing whitespace with HTTP 500. Signed-off-by: Henry Sachs <henry.sachs@deutschebahn.com>
Signed-off-by: Henry Sachs <henry.sachs@deutschebahn.com>
GitLab can return null, decoded as false by client-go. Fixes #447 Signed-off-by: Henry Sachs <henry.sachs@deutschebahn.com>
GitLab can return null, decoded as false by client-go. Refs #447 Signed-off-by: Henry Sachs <henry.sachs@deutschebahn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Refs #250
Why
Users cannot manage the GitLab project integrations for Jenkins, Microsoft Teams, or Telegram with the provider. This change adds a managed resource for each one. All three follow the
IntegrationHarborpattern.What changed
IntegrationJenkins,IntegrationMicrosoftTeams, andIntegrationTelegraminprojects.gitlab.m.crossplane.ioandprojects.gitlab.crossplane.io.projectIdRefandprojectIdSelectorresolve to aProject.enableSslVerificationand*Events; Teams and TelegramnotifyOnlyBrokenPipelinesand*Events): GitLab can returnnull, which client-go decodes asfalse. An unset field stays unset and is not compared;atProviderstill shows observed values. Fixes bug(projects): IntegrationJenkins late-inits null enableSslVerification as false #447Scope
hostnameorthread, and nonotifyOnlyWhenPipelineStatusChangesoruseInheritedSettings. The client-go option structs have no such fields.Blast Radius
The change adds new files and one registration line per kind in the shared setup and register files. Existing resources are not affected.
Verification
make generateleaves no diff. golangci-lint reports 0 issues on the touched packages.active: falseon all three integrations.projectIdRefresolution were not tested live.I have:
make reviewable testto ensure this PR is ready for review. I ran the parts separately:make generate,go build ./...,go teston the touched packages, and golangci-lint.