Skip to content

bug(projects): IntegrationJenkins late-inits null enableSslVerification as false #447

Open

Description

@henrysachs

What happened?

In PR #435, IntegrationJenkins late-initializes enableSslVerification from JenkinsCIServiceProperties.EnableSSLVerification. client-go types that field as bool, not *bool. When GitLab returns "enable_ssl_verification": null, which it does for a newly created integration that never had the field set, the value decodes as false, and the provider writes enableSslVerification: false into the spec.

GitLab documents the default as true. A user who leaves the field unset ends up with an explicit false in the spec, and the next update sends false to GitLab. That may turn SSL verification off explicitly.

Seen live on GitLab 19.4.2-ee while testing #435. Not verified: whether GitLab itself treats null as true or false when it calls Jenkins.

Possible fix

  • Skip late-init for enableSslVerification, or
  • Ask client-go to type the field as *bool.

Activity

  1. added 2 commits that reference this issue on Oct 15, 2026
    8805e7c
    6d4849c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions