Repository navigation
fix: reading pass 2: process rows fold in place, quiet notes, wide-content fades, one notice style - #167
Merged
Conversation
…rue math - Quiet tone: `ReplyTone` / `\.replyTone` lets secondary Markdown (compaction notes, runtime context) render at 12 pt on an 18 pt line in secondary ink. Before, the outer `.font` / `.secondary` never reached `ReplyText`. List markers follow the tone; the unused private `replyInk` is removed. - The native 展开完整问题 toggle matches SwiftUI: borderless, left-aligned at the text inset, secondary, 6 pt below the prompt on a 24 pt row. Row heights are unchanged. user-rows asserts it (UserMessageStyle.toggle* tokens). - Wide content: tables no longer reserve a legacy scroller band. Code cards (both renderers) and tables fade their trailing 12 pt while content overflows; the fade is visual only, and no glyph fades at the scrolled end. The table header rule is stronger than row rules; padding and rule opacities are `ReplyStyle.Table` tokens. - Math draws in the window's appearance: each formula is typeset in both colors and an image picks one at draw time, so a per-window light/dark override and live switches recolor inline and display math. Sizes are unchanged. - The warning alert title uses a darker amber in light mode; the bar and icon keep yellow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…language - Live thought and tool rows had no inset while the folded 思考与工具 row and commentary used the disclosure's default 8 pt, so a running turn jumped sideways as it folded. `ReplyStyle.Process` puts every process chevron at the reading column's edge. Nested content uses one 20 pt indent (it was 10, 14, 20 or 24). The fold label is secondary and regular. The hover wash keeps its reach through `leadingWashOutset`. Disclosure stays atomic. - Compaction notes and runtime context use the quiet reply tone. - The plan review preview shows plain text instead of raw Markdown, and its notes are 11 pt. - A language change now reaches transcript rows: the locale is part of `ConversationEntryAppearance`, so rows are reconciled and hosted rows get `.environment(\.locale, …)`. Native rows re-update, and views that build labels in code depend on the locale. - Build lists (navigation, reading, tool-visibility, workflow and performance previews, check-scroll-following) and the performance export test compile the new style file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Native agents showed errors, a lost connection and stale sync as 10 pt orange captions centered across the pane; Kimi used a 12 pt banner. Both now use `ConversationNotice`: a 12 pt line with a symbol and at most one action, in the reading column. Text, actions and when each shows are unchanged. - A queued prompt was full-width left-aligned 13 pt text, then jumped to the right-aligned bubble when the agent echoed it. It now renders as that bubble (UserMessageStyle, same Markdown, top spacing and trailing edge). Its mode, status and controls sit on one 11 pt line below it. The editing sheet is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third batch of the 2026-10-15 polish review (reading, second pass): one commit per area.
b5a4f74).font/.secondarynever reachedReplyText, so they read as body text.\.replyTonecarries the tone, and list markers follow it.2aa7a89)ReplyStyle.Processputs every process chevron at the column edge. Nested content uses one 20 pt indent; it was 10, 14, 20 or 24. The hover wash still reaches 8 pt before the chevron.330ed4d)ConversationNotice: 12 pt, a symbol and at most one action, in the reading column. Errors past 128 pt still scroll. Texts, actions and when each notice shows are unchanged.Verification
330ed4d(rebased on feat: codex 图标反色为白底墨色 knot，与 kimi 黑底月牙区分 #166): 8/8, including localization and preview source lists.user-rowsnow asserts the settled fold toggle's geometry and fails if no fixture exercised it.🤖 Generated with Claude Code