feat: composer and panels: ⌘Return for the next turn, arrows stay in multi-line drafts, one dialog convention, file viewer gutter

[chenweigao]

Stacked on #167 (reading pass 2), which it builds on: ConversationNotice, the pending-prompt bubble and PendingMessageContent's controls closure. Review only the last three commits here. Once #167 merges, I will rebase this onto main and retarget it.

Summary

Fifth batch of the 2026-10-15 polish review (composer and panels): one commit per area.

• Composer (bf3aa92)

  • While a turn runs, plain Return keeps doing what it did: Kimi steers, native agents that can steer steer, and the rest queue for the next turn. Where Return steers, ⌘Return now sends for the next turn; everywhere else it sends like Return. Each press sends once. The send menu shows 下一轮发送 ⌘↩ as text, not as a key equivalent, which a pop-up menu could fire while closed.

  • The placeholder says what Return does:

    • while running, 回车引导当前轮，⌘回车排到下一轮… or 回车排到下一轮发送…;
    • when idle, 继续此任务，或输入 / 使用命令… where the composer offers / commands, otherwise 继续此任务….

    VoiceOver reads it. The 11 pt Steer / Queue hint names both keys in its tooltip.

  • History recall no longer hijacks the arrows inside a recalled multi-line prompt. ↑ recalls only from an empty draft or the first visual line, and ↓ only from the last; elsewhere they move the caret. ComposerKey.up / .down carry the edge-line flag, read from the text view's TextKit 1 layout.

  Key	Kimi idle	Kimi running	Native idle	Native running
  Return	send	steer	send	steer if supported, else next turn (attachments: next turn)
  ⌘Return	send	next turn	send	next turn

• Dialogs and file viewer (b7e1db0)

  • Sheets share WorkbenchTheme.Dialog.padding (24; they used 16 to 28) and one button order: Spacer, the dismissing action (.cancelAction), the primary (.defaultAction).
  • The commit diff sheet and the new-task file sheet close on Escape; the side file panel does not.
  • The queued-message editor, code feedback and group suggestions sheets gain a default action.
  • Onboarding keeps 上一步 leading and moves 取消 next to the primary.
  • File viewer code uses the reply code style (12.5 pt, 4 pt spacing).
    • Line numbers sit in the scroll view's vertical ruler: right-aligned, padded to the widest number, not selectable. They scroll vertically with the code and never sideways. Code and numbers share one fixed line height, so CJK or emoji lines cannot drift.
    • Copy, quotes and feedback now read the source text directly instead of mapping back from "9 │ " prefixes, so ReviewContext.sourceSelection is removed. Lines count as TextKit breaks them (CRLF included), and a final newline gets no number.

• Labels and copy (090479d)

  • Icon-only controls without an accessibility label get one from their tooltip: 18 controls across the composer, file panel, sidebar, find controls, activity bar and workbench.
  • Hit targets grew only where nothing else moves: the project header's + went from 26 to 28. Everywhere else, 28 pt would make a row taller, and transcript rows get labels only.
  • Onboarding's model picker now says it sets the default model for new tasks; before, it said "next message".
  • The settings toggle 启动时自动连接 is now 自动连接, because flipping it connects or disconnects at once.

Verification

• Linux portable suite on clean head 090479d: 8/8, including localization (1245 keys) and preview source lists (19 builds; three previews now compile WorkbenchTheme.swift).
• Linux WorkbenchCore + WorkbenchChecks: 58 PASS, including the updated review-context check. The AppKit math test is skipped here.
• Tests/ComposerChecks (macOS step "composer") covers:
  • ⌘Return / ⌃Return / Shift / Option;
  • the recall decision with edge-line inputs;
  • NSTextView edge lines across hard breaks, soft wraps, upstream affinity at a wrap and a final empty line.
• Not run locally: no macOS SDK here, so the macOS job is the first compile.
• Mac checks needed:
  • ⌘Return in a running Kimi and native turn sends once, for the next turn.
  • The placeholder switches as a turn starts and ends.
  • ↑/↓ move through a recalled multi-line prompt.
  • Return in the queued-message editor and code feedback sheets now submits. As in the composer, Shift-Return should add a line; if that is unwanted, I'll drop the default action there.
  • Escape on the commit and new-task file sheets.
  • The file viewer gutter with CJK and CRLF files, fast scrolling and sideways scrolling.
  • Sheet spacing.
  • VoiceOver on the new labels.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-15T14:12:34.693620Z	090479d	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 090479dd74

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Exclude slash commands from the next-turn action

When a native session is running and the draft is a recognized command such as /compact, defaultMode(s) is still .steer, so this exposes ⌘Return and the menu as “Send next turn.” However, NativeAgentConnection.send detects commands before enqueueing and ignores the supplied .nextTurn mode, executing the command immediately instead. This makes the advertised next-turn action perform immediate work or fail against the active turn; mirror the Kimi composer by withholding onQueue for command drafts.

Useful? React with 👍 / 👎.