Repository navigation
fix: sidebar and interaction consistency: legible badges, one highlight scale, keyboard queue, one vocabulary - #169
Merged
Conversation
…ws never look hovered - `WorkbenchTheme.Fill` (hover .045, selected .08, pressed .11, surface .035), `Stroke.hairline` (.08) and `Radius` (row 7, chip 5, card 10) replace eight hover strengths, ad-hoc selection fills and assorted radii in content views: disclosures, the slash-command palette, model and directory pickers, file references, the selection bar, find toggles, the turn rail and floating controls, file lists, plan and agent cards. - Lists with a keyboard row (slash commands, directories, file references, the turn rail) draw it as `selected` and the pointer's row as `hover`. When both fall on one row, selected wins, so two rows never look chosen. Disclosure buttons take a `selected` state for this. - Disclosure rows, transcript process rows included, now hover at .045 and press at .11 (were .025 and .05). Frames and paddings are unchanged. Glass and reply-block radii keep their own values; MessageComposer keeps literals because check-composer.sh compiles it without the theme. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…first-run sidebar - Compact status badges cut a 1.25 pt gap out of the agent mark, so an orange ! on an orange Claude, Qoder or OMP mark, or the blue dot on DeepSeek, stays legible. The gap shows the glass; nothing is painted. Offline is `wifi.slash`, as in the full indicator and the environments list. - The project header's highlight spans the row, count and + included, and a press shows on the whole row. The 项目 section menu shows an ellipsis instead of a chevron that read like 置顶's fold, with a hover fill and the label 项目视图选项. Shortcut hints (⌘K, ⌘, and ⇧⌘N) share one 11 pt size. Every sidebar highlight draws through `SidebarHighlight`; `SidebarMetrics.fill` and `cornerRadius` read the theme tokens. - First run: the 置顶 invitation waits for a session it could pin. With no machine configured, the footer offers 添加机器… (⇧⌘N). - Task groups use `square.stack.3d.up`; remote machines and 环境管理 use `server.rack`, so `desktopcomputer` only means this Mac. - Copy: the search sheet is 搜索项目与会话, add-machine controls say 添加机器…, empty lists say 新会话会出现在这里. - The localization preview compiles WorkbenchTheme.swift; the sidebar preview app uses the same terms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…board icons and copy - Queue rows have a focusable open target behind their content. Tab reaches it with or without Keyboard Navigation, Return or Space opens the session, and VoiceOver reads a button with the title and metadata. Group links stay separate controls. 已查看 and 管理归属 show on focus as on hover; 标为已查看 is also in the context menu and a VoiceOver action. Keyboard focus reads as selected, the pointer as hover. - Task groups use `square.stack.3d.up` (dashboard, header, projection); the empty state's start button uses `square.and.pencil`; an agent that is not connected shows `wifi.slash` in the new-session machine list. - Dashboard, header, onboarding and setup copy use the canonical terms: 会话… in the 新建 menu, 添加机器… for every add-machine entry, 开始首个会话, 连接并新建会话, and 机器 instead of 运行环境 in the new-session picker. - Dashboard fills and radii use the theme tokens; the workbench preview app shows the task group symbol. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- English values follow the canonical terms. 会话 is Session / sessions (no more chats or conversations for sessions), 工作台 is Workbench, 任务组 is Task Group(s), 机器 is Machine: 53 values, each keeping its capitalization style. - Menus: 新建会话 · ⌘N, 搜索项目与会话 (⌘K) and 下一个待处理会话 (⇧⌘J). - English-literal keys that said task or conversation for a session move to Chinese keys in session terms: the Kimi load error, the /goal and first-message notices, and the missing execution environment. KimiWorkspaceView also takes the card and row radius tokens. - Localization tables: 13 new keys for this batch; 20 keys no code uses any more are removed. LocalizationChecks expects 工作台 → Workbench. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #168, which is stacked on #167. Batch 4 changes the same sidebar files and localization tables, so only the last four commits are new here. After the earlier PRs merge I'll rebase this onto main and retarget it.
Summary
Fourth batch of the 2026-10-15 polish review (sidebar and interaction consistency), with every recommendation approved: one commit per area.
132d835)WorkbenchTheme.Fill(hover .045, selected .08, pressed .11, surface .035),Stroke.hairlineandRadius(row 7, chip 5, card 10) replace eight hover strengths, ad-hoc selection fills and assorted radii in content views.selectedand the pointer rowhover. If both fall on one row, selected wins, so two rows never look chosen.35a9dd1)wifi.slasheverywhere.square.stack.3d.up, remote machinesserver.rack, this Macdesktopcomputer.02a815b)accc74f)Verification
accc74f: 8/8, covering localization (1237 keys, both tables in step) and preview source lists (19 builds; the localization preview now compilesWorkbenchTheme.swift).WorkbenchDisclosureStylemetrics and the model-picker row pitch are untouched; CI checks them.🤖 Generated with Claude Code