feat(client): toggle default and dev metaserver providers by zoeyrose · Pull Request #572 · atrinik/classic

zoeyrose · 2026-10-09T00:54:04Z

Summary

Add an always-visible button to the Classic intro screen that switches the server listing between the default and development metaserver providers. Its label shows the destination: Dev on the default provider and Default on the development provider.

Implementation / behavior

Switch both directory and rendezvous endpoints together:
- Default: classic.metaserver.atrinik.org and rendezvous.meta.atrinik.org.
- Development: classic.dev.metaserver.atrinik.org and rendezvous.dev.meta.atrinik.org.
Keep the choice session-only. Startup endpoint overrides remain effective until the button is clicked; clicking also enables discovery after --nometa.
Refresh the list without blocking the intro screen. Workers own endpoint snapshots, obsolete results are discarded, and repeated switches coalesce into the latest request.
Invalidate copied server rows even when providers return the same number of entries. Clear the selected server and pending access-code attempts when switching providers. Access workers retain endpoint snapshots, and provider switches cancel them without blocking.
Cover provider lifecycle, stale results, shutdown, and both button directions in the offline intro fixtures. Route provider clicks ahead of the active access-code popup and verify this through the production SDL input queue, including cancellation and unrelated modal blocking.

Validation

Validated integration revision: b49818be8c271203116f5d73439a1d7b7a5e545e, merged with main at f7da19591ce104ae27d52dbd5ba7cce9a835505f.

Pinned Classic build image 1.16.0: client build passed; 71 tests passed and 24 GPU tests skipped.
Focused metaserver options, provider lifecycle and access-resolver tests: all three passed with coverage instrumentation and under ASan/UBSan.
Focused metaserver/access-worker coverage: 85.8% lines, 96.2% functions, 56.3% branches.
Offline software Vulkan: 18 UI closure states and nine book editor states passed; strict record verification and screenshot artifact hashes passed.
GPU verification Python tests: 24 passed.
Imported component history and whitespace verification passed.
Independent concurrency and ownership review found no actionable issues.
Final-head Codex code and security reviews completed without findings; all review threads are resolved.
GitHub Check and CodeQL passed, including trusted software GPU coverage and native Windows security tests.

Limitations / follow-up

UI validation uses offline software Vulkan; it does not constitute physical GPU qualification.

zoeyrose · 2026-10-09T01:08:49Z

@codex review

Please review the current head 7bbe3efcf29a49344aa2c5665163217ca3adc8bd, including the integration with access-code endpoint snapshots and cancellation when switching metaserver providers. Conflicts with current main are resolved; fresh build, sanitizer and offline UI validation are running.

chatgpt-codex-connector · 2026-10-09T01:09:09Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-09T01:49:22.501786Z	`b49818b`	Draft marked ready
🔒 Security Review	✅ Completed 2026-10-09T01:50:12.288526Z	`b49818b`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7bbe3efcf2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-09T01:12:54Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 7bbe3efcf2

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

codecov · 2026-10-09T01:13:58Z

Codecov Report

❌ Patch coverage is 62.23958% with 145 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
client/src/client/gpu_player_view.c	48.69%	43 Missing and 55 partials ⚠️
client/src/client/metaserver.c	80.48%	14 Missing and 2 partials ⚠️
client/src/client/metaserver_options.c	70.96%	1 Missing and 8 partials ⚠️
client/src/gui/misc/intro.c	80.00%	4 Missing and 4 partials ⚠️
client/src/gui/popups/access_code.c	61.53%	1 Missing and 4 partials ⚠️
client/src/client/access_resolver.c	78.94%	2 Missing and 2 partials ⚠️
client/src/events/event.c	40.00%	0 Missing and 3 partials ⚠️
client/src/client/main.c	0.00%	1 Missing ⚠️
client/src/client/metaserver_direct.c	0.00%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

zoeyrose · 2026-10-09T01:18:37Z

@codex review

Please review head 9d7f85cdf33096f1899653bbde0d90985cee84dc. It addresses the modal-routing feedback with access-popup-only priority for uncovered provider clicks, plus a regression that queues events through Event_PollInputDevice() and verifies resolver cancellation, endpoint snapshot isolation and unrelated modal blocking. Independent review and focused coverage/ASan/UBSan checks passed; the full build and offline UI checks are running.

chatgpt-codex-connector · 2026-10-09T01:20:23Z

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 9d7f85cdf3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-09T01:22:11Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 9d7f85cdf3

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

zoeyrose · 2026-10-09T01:32:42Z

@codex review

Final validated head: b49818be8c271203116f5d73439a1d7b7a5e545e. The last update fixes offline fixture initialization to service startup window/GPU recovery and preserve SDL text-input state. The production modal-routing fix is unchanged from your previous review. The real SDL input/cancellation regression, strict offline UI/artifact verification, full client suite and focused ASan/UBSan tests now all pass.

chatgpt-codex-connector · 2026-10-09T01:35:11Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: b49818be8c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-09T01:35:46Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: b49818be8c

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

## Summary Correct the Classic directory hostnames introduced in #572, which made server-list discovery fail with a hostname-resolution error. ## Implementation / behavior - Use `classic.meta.atrinik.org` for Default and `classic.dev.meta.atrinik.org` for Dev. - Synchronize packaged configuration, provider selection, intro tooltips, documentation, and existing options/lifecycle/GPU assertions. - Preserve the rendezvous/access endpoints and protocol/TLS validation. ## Validation - Both affected native tests pass: `client-metaserver-options` and `client-metaserver-lifecycle`, compiled with warnings as errors in the pinned Classic build 1.16.0 CPU image. - Imported-history verification passes for all five components. - `git diff --check` passes. - Independent review of final commit `145686fcf1f5adb040b10fba843e2ce6d2e41209` found no blocking defects. - Required client CI is pending; this PR starts as a draft. ## Limitations / follow-up The production directory currently serves protocol 4; this client requires protocol 6. This hostname-only correction does not resolve that separate compatibility issue or the game-news certificate error.

zoeyrose added 11 commits October 8, 2026 18:42

feat(client): add intro metaserver provider toggle

7d96767

test(client): cover metaserver provider lifecycle

4f42f08

fix(client): clear destroyed button font ownership

0309307

test(client): strengthen metaserver lifecycle coverage

993b062

feat(client): switch metaserver providers without blocking the intro

f8676a6

test(client): avoid lifecycle poll race

2a4f1ee

fix(client): use SDL3 condition broadcasts in metaserver tests

3874531

test(client): refresh intro provider text baseline

65fedbd

test(client): refresh startup provider text baselines

ee4a11d

fix(client): integrate provider toggle with current access services

9a95561

fix(client): include access resolver settings definition

7bbe3ef

chatgpt-codex-connector Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread client/src/gui/misc/intro.c Outdated

fix(client): route provider clicks during access resolution

9d7f85c

test(client): reconcile queued provider fixture input

b49818b

zoeyrose marked this pull request as ready for review October 9, 2026 01:46

zoeyrose merged commit 9f208e5 into main Oct 10, 2026
29 checks passed

zoeyrose deleted the feat/client-metaserver-toggle branch October 10, 2026 18:39

zoeyrose mentioned this pull request Oct 11, 2026

fix(client): correct default and dev metaserver hostnames #587

Merged

Navigation Menu

Repository navigation

feat(client): toggle default and dev metaserver providers - #572

feat(client): toggle default and dev metaserver providers#572
zoeyrose merged 13 commits into
mainfrom
feat/client-metaserver-toggle

zoeyrose commented Oct 9, 2026 •

edited

Loading

Uh oh!

zoeyrose commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026

Uh oh!

codecov Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

zoeyrose commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026

Uh oh!

zoeyrose commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

zoeyrose commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Implementation / behavior

Validation

Limitations / follow-up

Uh oh!

zoeyrose commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

codecov Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zoeyrose commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

zoeyrose commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

zoeyrose commented Oct 9, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading

codecov Bot commented Oct 9, 2026 •

edited

Loading