Repository navigation
fix(client): correct default and dev metaserver hostnames - #587
Merged
Merged
Conversation
zoeyrose
marked this pull request as ready for review
October 11, 2026 04:31
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the Classic directory hostnames introduced in #572, which made server-list discovery fail with a hostname-resolution error.
Implementation / behavior
classic.meta.atrinik.orgfor Default andclassic.dev.meta.atrinik.orgfor Dev.Validation
client-metaserver-optionsandclient-metaserver-lifecycle, compiled with warnings as errors in the pinned Classic build 1.16.0 CPU image.git diff --checkpasses.145686fcf1f5adb040b10fba843e2ce6d2e41209found no blocking defects.Limitations / follow-up
The production directory currently serves protocol 4; this client requires protocol 6. This hostname-only correction does not resolve that separate compatibility issue or the game-news certificate error.