Remove blocksScanApi creation-tx fetcher - #2948
Open
kuzdogan wants to merge 1 commit into
Open
Conversation
The only chain that used it was XDC Apothem (51), whose BlocksScan instance at https://apothem.xdcscan.io/ is down (HTTP 521). The chain is discovered by dRPC and Etherscan and Etherscan v2 returns its creation tx, so the manual override is being removed from sourcify-chains and the server no longer needs this code path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
can we merge this after #2947 ? |
This was referenced Aug 27, 2026
Member
Author
|
Companion PR that removes the chain 51 override from the chain config: sourcifyeth/sourcify-chains#129 Posted with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blocksScanApioption fromFetchContractCreationTxMethodsin lib-sourcify and the matching fetcher / branch in the server'sgetCreatorTx.Why
The only chain that used
blocksScanApiwas XDC Apothem Testnet (51), pointing athttps://apothem.xdcscan.io/. That endpoint is down (HTTP 521). The chain is auto-discovered by dRPC and Etherscan, and the Etherscan v2 API already returns its creation tx, so the manual override is being removed fromsourcifyeth/sourcify-chains(companion PR linked in the comments) and this code path has no users left.Notes
blocksScanApiis dropped from the lib-sourcify type, so a self-hostedsourcify-chains.jsonthat still sets it will fail type-checking. Minor breaking change for lib-sourcify.🤖 Generated with Claude Code