ci: split live creation-tx API tests into their own CI job - #2947
Open
marcocastignoli wants to merge 2 commits into
Open
ci: split live creation-tx API tests into their own CI job#2947marcocastignoli wants to merge 2 commits into
marcocastignoli wants to merge 2 commits into
Conversation
The getCreatorTx tests against live third-party APIs (Blockscout, Routescan, Etherscan, NodeReal, VeChain, Nexus) fail test-server whenever a provider degrades — NodeReal has been red on every run since Aug 25. Move them to test/creation-tx-apis/ and run them in a separate test-creation-tx-apis job that no other job requires, so a provider outage shows as its own GitHub status while test-server stays green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
|
The commented-out chain 51 (XDC Apothem) test can be removed entirely instead of carried over. Posted with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCreatorTxtests that call live third-party APIs (Blockscout, Routescan, Etherscan, Avalanche, VeChain, NodeReal, Nexus) fromtest/unit/intoservices/server/test/creation-tx-apis/, outside thetest-serverglobs.test:creation-tx-apisnpm script and a new CircleCI jobtest-creation-tx-apisin both workflows. No other job requires it.Why
test-serverhas failed on every CI run since Aug 25 because NodeReal'snr_getContractCreationTransactionstopped returning the creation tx (the CI key gets a response with noresult.hash; production BSC currently falls back to Etherscan). Any of the live providers in that loop can take CI hostage the same way — there's precedent in the file (chain 51 test commented out, live binary-search test skipped).CircleCI reports one GitHub status per job, and staging has no required status checks, so after this change a provider outage shows up as a red
ci/circleci: test-creation-tx-apisline on PRs whiletest-serverstays green and meaningful. The live coverage still runs on every PR, so "the external service is really failing" remains visible.Notes
test-creation-tx-apiswill be red from day one: the NodeReal integration is genuinely broken. Someone with access to the NodeReal dashboard should check the key/plan.CIRCLE_PR_REPONAME), and NodeReal keeps its skip whenNODEREAL_API_KEYis unset.🤖 Generated with Claude Code