Repository navigation
feat: detect chain network from address format - #26
Closed
salazarsebas wants to merge 1 commit into
Closed
salazarsebas wants to merge 1 commit into
salazarsebas wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 9, 2026
Contributor
Author
Contributor
Author
|
Duplicate of #24. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #10.
apps/webno longer hardcodesnetwork: \"tron\"for every destination.parseDestinationAddresslives inpackages/core(the UI must not own this rule). It infers Tron from a 34-characterT...base58 address and Ethereum from0xplus 40 hex characters. Anything else is rejected instead of being stored under the wrongnetwork:valuerisk-list key.The send form shows a field-level error for unrecognized input and surfaces the detected network on the assessment so a Tron vs Ethereum paste is visible.
Test plan
pnpm --filter @custos/core test(includes 5 new parse tests)pnpm run buildpnpm run typecheckpnpm --filter @custos/web buildT...address and confirm the result says Tron0x...address and confirm Ethereumbc1...or a short0xand confirm the form errors without analyzingCloses #10