Repository navigation
Align Questionnaire Catalog with Grove FHIR - #47
Open
PSchmiedmayer wants to merge 31 commits into
Open
PSchmiedmayer wants to merge 31 commits into
PSchmiedmayer wants to merge 31 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task done
PSchmiedmayer
added a commit
to SchmiedmayerLab/.github
that referenced
this pull request
Sep 23, 2026
### ♻️ Current situation & Problem `swift-test.yml` builds with a plain `swift build` before `swift test`, and its only passthrough, `test_flags`, reaches `swift test` alone. A caller therefore cannot pass options both commands must share, such as a build system or compiler flags. This is needed now because Swift 6.4.0's default build system compiles targets that are only reachable through an inactive platform condition ([swiftlang/swift-package-manager#10538](swiftlang/swift-package-manager#10538)). On Linux, consumers of Grove fail in `GroveKeychainStorage` (`no such module 'Security'`) until the fix, already backported in [#10556](swiftlang/swift-package-manager#10556), ships in a 6.4.x release. With `build_flags: '--build-system native'` they can build until then. ### ⚙️ Release Notes - Add a `build_flags` input to `swift-test.yml`, passed to both `swift build` and `swift test`; it defaults to empty, so existing callers are unchanged. - Clarify that `test_flags` is passed to `swift test` only. ### 📚 Documentation The input descriptions and the Run Swift Tests section of the README explain which flags go where. ### ✅ Testing `actionlint` passes, and the flag expansion was checked for an empty, a single and a multi-flag value. The first callers are SchmiedmayerLab/MyHeartCounts-StudyDefinitions#47 and SchmiedmayerLab/MyHeartCounts-iOS#204 once this is released. ### Code of Conduct & Contributing Guidelines - [x] I agree to follow the [Code of Conduct](https://github.com/SchmiedmayerLab/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/SchmiedmayerLab/.github/blob/main/CONTRIBUTING.md).
1 task done
lukaskollmer
added this pull request to stack #51
September 28, 2026 05:52
lukaskollmer
self-requested a review
September 28, 2026 06:06
lukaskollmer
approved these changes
Sep 28, 2026
…G/MyHeartCounts-StudyDefinitions into feature/grove-questionnaire-contract # Conflicts: # .github/workflows/verify-study-bundle.yml # Package.swift # README.md # Sources/MHCStudyDefinitionExporter/Study.swift # Tests/MHCStudyDefinitionExporterTests/MHCStudyDefinitionExporterTests.swift
lukaskollmer
marked this pull request as ready for review
September 28, 2026 06:54
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
The Questionnaire catalog predates the current Grove FHIR contract. Its localized resources use obsolete profile metadata, nonstandard context coding, legacy Quantity extensions, and structural defaults that no longer validate cleanly. The catalog also has no executable guarantee that English and Spanish definitions preserve the same canonical and answer contract or that Grove can import and export every Questionnaire.
Localized instruments were also published as separate resources under one
url|version, which the Grove FHIR contract (SchmiedmayerLab/grove-fhir#42) now forbids: one instrument is one multilingual Questionnaire.⚙️ Release Notes
active, version0.1.0, with the standard semantic-version algorithm.questionnaire-unitOptionand the SDC Quantity bounds.050ba883b2fdea6a91d93d2405e4121ca9a736cf(Disable lowered deployment targets by default Grove#116), including the FHIR APIs and standard deployment targets, while the coordinated repositories land.en-USbase withes-UStranslationextensions, merged from the per-locale sources, which stay the authoring format.--build-system nativeuntil Swift 6.4.x ships the fix for [SwiftBuild] Dependencies of conditionally excluded deps get compiled swiftlang/swift-package-manager#10538.studyRevisionfrom 44 to 48.📚 Documentation
The validated Questionnaire resources remain the authoritative catalog. The README describes the per-locale sources, the multilingual export, and the rule that any translation change needs a new version.
✅ Testing
swift testpasses, including Grove diagnostics, import, and export for every localized Questionnaire.66f0a88eand grove-fhir9c5eff4: 8 tests pass on macOS and on Linux (native build system); the export yields 14 merged Questionnaires whose every translation matches its source, and grove-fhir's paired and official validators accept them together with an English HeartRisk and a Spanish GAD-7 response.Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: