Repository navigation
Let Callers Pass Build Flags to the Swift Test Workflow - #38
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
swift-test.ymlbuilds with a plainswift buildbeforeswift test, and its only passthrough,test_flags, reachesswift testalone.A caller therefore cannot pass options both commands must share, such as a build system or compiler flags.
This is needed now because Swift 6.4.0's default build system compiles targets that are only reachable through an inactive platform condition (swiftlang/swift-package-manager#10538).
On Linux, consumers of Grove fail in
GroveKeychainStorage(no such module 'Security') until the fix, already backported in #10556, ships in a 6.4.x release.With
build_flags: '--build-system native'they can build until then.⚙️ Release Notes
build_flagsinput toswift-test.yml, passed to bothswift buildandswift test; it defaults to empty, so existing callers are unchanged.test_flagsis passed toswift testonly.📚 Documentation
The input descriptions and the Run Swift Tests section of the README explain which flags go where.
✅ Testing
actionlintpasses, and the flag expansion was checked for an empty, a single and a multi-flag value.The first callers are SchmiedmayerLab/MyHeartCounts-StudyDefinitions#47 and SchmiedmayerLab/MyHeartCounts-iOS#204 once this is released.
Code of Conduct & Contributing Guidelines