Skip to content

Let Callers Pass Build Flags to the Swift Test Workflow - #38

Merged
PSchmiedmayer merged 1 commit into
mainfrom
feature/swift-test-build-flags
Sep 23, 2026
Merged

PSchmiedmayer merged 1 commit into
mainfrom
feature/swift-test-build-flags

Conversation

@PSchmiedmayer

Copy link
Copy Markdown
Contributor

♻️ Current situation & Problem

swift-test.yml builds with a plain swift build before swift test, and its only passthrough, test_flags, reaches swift test alone.
A caller therefore cannot pass options both commands must share, such as a build system or compiler flags.

This is needed now because Swift 6.4.0's default build system compiles targets that are only reachable through an inactive platform condition (swiftlang/swift-package-manager#10538).
On Linux, consumers of Grove fail in GroveKeychainStorage (no such module 'Security') until the fix, already backported in #10556, ships in a 6.4.x release.
With build_flags: '--build-system native' they can build until then.

⚙️ Release Notes

  • Add a build_flags input to swift-test.yml, passed to both swift build and swift test; it defaults to empty, so existing callers are unchanged.
  • Clarify that test_flags is passed to swift test only.

📚 Documentation

The input descriptions and the Run Swift Tests section of the README explain which flags go where.

✅ Testing

actionlint passes, and the flag expansion was checked for an empty, a single and a multi-flag value.
The first callers are SchmiedmayerLab/MyHeartCounts-StudyDefinitions#47 and SchmiedmayerLab/MyHeartCounts-iOS#204 once this is released.

Code of Conduct & Contributing Guidelines

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: cb2eee2b-2f20-471d-961a-4cf6ec7e6288


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@PSchmiedmayer
PSchmiedmayer merged commit bb45a48 into main Sep 23, 2026
6 checks passed
@PSchmiedmayer
PSchmiedmayer deleted the feature/swift-test-build-flags branch September 23, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant