Repository navigation
Pin Grove to the FHIR review fixes - #52
Open
lukaskollmer wants to merge 1 commit into
Open
lukaskollmer wants to merge 1 commit into
lukaskollmer wants to merge 1 commit into
Conversation
MyHeartCounts pins Grove by revision and depends on this package, and SwiftPM refuses two different revision requirements for one package. Track the head of SchmiedmayerLab/Grove#117 (stacked on #116), which fixes the State of Mind, partial-extraction and SensorKit recovery issues found in the FHIR stack review. Extraction expectations here are unchanged: HeartRisk answers every marked item. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PaulGoldschmidt
approved these changes
Sep 28, 2026
lukaskollmer
added a commit
to SchmiedmayerLab/MyHeartCounts-iOS
that referenced
this pull request
Sep 28, 2026
Grove moves to 611d0cd8 (SchmiedmayerLab/Grove#117), which adds SensorKit.discardPendingBatches(for:) used by the SensorKit recovery above and fixes the State of Mind, partial-extraction, breathing-disturbance, ECG timing and DST issues. StudyDefinitions moves to d1cbe285 (SchmiedmayerLab/MyHeartCounts-StudyDefinitions#52), which only re-pins Grove, because SwiftPM rejects two different revision requirements for Grove. Pinned in the project, MyHeartCountsShared, Package.resolved and the submodule. A half-answered blood-pressure panel still refuses, but Grove now reports it as componentIncomplete instead of answerMissing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 28, 2026
lukaskollmer
added this pull request to stack #51
September 28, 2026 15:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
Stack: 3/3, following #47. SchmiedmayerLab/Grove#117 fixes problems found in the review of the Grove FHIR stack: State of Mind samples were refused, and skipping one optional marked question dropped every extracted reading of a response. It sits on top of SchmiedmayerLab/Grove#116, which #47 pins today.
MyHeartCounts pins Grove by revision and depends on this package. SwiftPM refuses two different revision requirements for one package, so MyHeartCounts can only move to the fixed Grove if this package moves with it.
⚙️ Release Notes
611d0cd8, the head of Fix Data Loss and Stuck Collection Found in the FHIR Stack Review Grove#117.📚 Documentation
No documentation changes.
✅ Testing
No test expectation changes.
HeartRiskExtractionTestsanswers every marked item, so Grove's new handling of unanswered items does not affect it. Not run locally: CI builds and tests the package against the new pin. SchmiedmayerLab/MyHeartCounts-iOS resolves and compiles against this commit.Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:
🤖 Generated with Claude Code