Repository navigation
Disable lowered deployment targets by default - #116
Open
lukaskollmer wants to merge 1 commit into
Open
lukaskollmer wants to merge 1 commit into
lukaskollmer wants to merge 1 commit into
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lukaskollmer
added this pull request to stack #112
September 28, 2026 07:53
1 task done
PaulGoldschmidt
self-requested a review
September 28, 2026 08:57
PaulGoldschmidt
approved these changes
Sep 28, 2026
PaulGoldschmidt
left a comment
PaulGoldschmidt
left a comment
There was a problem hiding this comment.
a stack of eight? In this economy?
Collaborator
Author
|
@PaulGoldschmidt stacking will continue until morale improves |
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation & Problem
Stack: 8/8, following #94. The current default enables lowered deployment targets, which excludes FHIRModels from watchOS. My Heart Counts uses GroveStudyDefinition on its watch companion and already targets iOS 18/watchOS 11, so that default prevents its dependency graph from building (SchmiedmayerLab/MyHeartCounts-iOS#204).
⚙️ Release Notes
GROVE_LOWERED_DEPLOYMENT_TARGETS=1.Textualenabled, withMLXandResearchKitopt-in.📚 Documentation
Updated the manifest comment to describe the default and explicit opt-in.
✅ Testing
1; verified platform floors and watchOS FHIR dependency availability in both configurations.git diff --checkpasses.Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: