examples(oxr): package under isaacteleop_examples - #1046
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
8af5275 to
5e4cf3e
Compare
5e4cf3e to
eb0631b
Compare
eb0631b to
d33cb08
Compare
d33cb08 to
9a023d0
Compare
9a023d0 to
17107f8
Compare
|
The scripts themselves are fine either way: they only import |
17107f8 to
c2ce879
Compare
No flat sibling imports -- the scripts are independent -- but the tree kept its pyproject under python/ and ran as `uv run <script>.py`, so it needed the same conversion for one install command to work everywhere. The GPU CI keeps invoking these by path rather than by -m. The test image copies examples/oxr/python/ to /app/tests and runs `python <script>`, so the list entries just gain the namespace prefix; with no sibling imports the path-based invocation is still correct. Converting that container to -m would mean changing the Dockerfile, the compose runner and the list together, on a path with no local reproduction. The example carried two overlapping READMEs, at the example root and under python/. The python/ one was a subset, so it goes and the root one absorbs its run commands. Part of #985. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
c2ce879 to
4794fbc
Compare
Description
Part of #985. Stacked on #1045.
No flat sibling imports — these scripts are independent — but the tree kept its
pyproject.tomlunderpython/and ran asuv run <script>.py, so it needed the same conversion for one install command to work across every example.The GPU CI keeps invoking these by path, not by
-m. The test image copiesexamples/oxr/python/to/app/testsand runspython <script>, so the entries inCXR_PYTHON_GPU_TESTSjust gain the namespace prefix. With no sibling imports the path-based invocation stays correct. Moving that container to-mwould mean changingDockerfile.test, the compose runner and the list together, on a path I cannot reproduce locally — worth doing, but not blind and not here.The example carried two overlapping READMEs, at the example root and under
python/. Thepython/one was a subset, so it goes and the root one absorbs its run commands.Type of change
Testing
x86_64/ Ubuntu, Python 3.12. Wheel ships 12 modules underisaacteleop_examples/oxr/with no namespace__init__.py.pre-commitclean.Not covered: everything here needs a headset and the CloudXR runtime. The CI list change is the risky part — please confirm the GPU job still finds all three scripts.
Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCONo tests: this is a move with no import changes.