Skip to content

examples(oxr): package under isaacteleop_examples - #1046

Open
jiwenc-nv wants to merge 1 commit into
jiwenc-nv/examples-cloudxr-mujoco-teleopfrom
jiwenc-nv/examples-oxr
Open

examples(oxr): package under isaacteleop_examples#1046
jiwenc-nv wants to merge 1 commit into
jiwenc-nv/examples-cloudxr-mujoco-teleopfrom
jiwenc-nv/examples-oxr

Conversation

@jiwenc-nv

@jiwenc-nv jiwenc-nv commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Description

Part of #985. Stacked on #1045.

No flat sibling imports — these scripts are independent — but the tree kept its pyproject.toml under python/ and ran as uv run <script>.py, so it needed the same conversion for one install command to work across every example.

uv pip install -e ./examples/oxr
python -m isaacteleop_examples.oxr.test_modular

The GPU CI keeps invoking these by path, not by -m. The test image copies examples/oxr/python/ to /app/tests and runs python <script>, so the entries in CXR_PYTHON_GPU_TESTS just gain the namespace prefix. With no sibling imports the path-based invocation stays correct. Moving that container to -m would mean changing Dockerfile.test, the compose runner and the list together, on a path I cannot reproduce locally — worth doing, but not blind and not here.

The example carried two overlapping READMEs, at the example root and under python/. The python/ one was a subset, so it goes and the root one absorbs its run commands.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

x86_64 / Ubuntu, Python 3.12. Wheel ships 12 modules under isaacteleop_examples/oxr/ with no namespace __init__.py. pre-commit clean.

Not covered: everything here needs a headset and the CloudXR runtime. The CI list change is the risky part — please confirm the GPU job still finds all three scripts.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

No tests: this is a move with no import changes.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d4b28cbd-a1ee-4707-81ef-0c88019c8122

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oxr branch from 8af5275 to 5e4cf3e Compare August 28, 2026 05:01
@jiwenc-nv
jiwenc-nv changed the base branch from jiwenc-nv/examples-deviceio-live-view to jiwenc-nv/examples-cloudxr-mujoco-teleop August 28, 2026 05:02
@jiwenc-nv
jiwenc-nv requested a review from ivany-nv August 28, 2026 05:11
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oxr branch from 5e4cf3e to eb0631b Compare August 28, 2026 05:23
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oxr branch from eb0631b to d33cb08 Compare August 28, 2026 05:33
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oxr branch from d33cb08 to 9a023d0 Compare August 28, 2026 05:44
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oxr branch from 9a023d0 to 17107f8 Compare August 28, 2026 05:49
@ivany-nv

Copy link
Copy Markdown
Contributor

run_tests_with_cloudxr.sh now uses isaacteleop_examples/oxr/test_*.py relative to /app/tests, described as a copy of examples/oxr/python/. Nothing in this repo creates /app/tests, so I can't check it here -- worth confirming against whatever builds the test image rather than letting the GPU job find out.

The scripts themselves are fine either way: they only import isaacteleop.*, no intra-example imports, so running them as bare scripts still works.

@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oxr branch from 17107f8 to c2ce879 Compare August 28, 2026 14:47
No flat sibling imports -- the scripts are independent -- but the tree kept its
pyproject under python/ and ran as `uv run <script>.py`, so it needed the same
conversion for one install command to work everywhere.

The GPU CI keeps invoking these by path rather than by -m. The test image
copies examples/oxr/python/ to /app/tests and runs `python <script>`, so the
list entries just gain the namespace prefix; with no sibling imports the
path-based invocation is still correct. Converting that container to -m would
mean changing the Dockerfile, the compose runner and the list together, on a
path with no local reproduction.

The example carried two overlapping READMEs, at the example root and under
python/. The python/ one was a subset, so it goes and the root one absorbs its
run commands.

Part of #985.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-oxr branch from c2ce879 to 4794fbc Compare August 28, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants