examples(teleop): package under isaacteleop_examples - #1047
Open
jiwenc-nv wants to merge 1 commit into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop
branch
from
August 28, 2026 05:01
c5248c8 to
e9d92d0
Compare
jiwenc-nv
changed the base branch from
jiwenc-nv/examples-deviceio-live-view
to
jiwenc-nv/examples-oxr
August 28, 2026 05:02
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop
branch
from
August 28, 2026 05:23
e9d92d0 to
554a238
Compare
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop
branch
from
August 28, 2026 05:33
554a238 to
5e763e5
Compare
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop
branch
from
August 28, 2026 05:45
5e763e5 to
862dd38
Compare
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop
branch
from
August 28, 2026 05:49
862dd38 to
7f4f71d
Compare
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop
branch
from
August 28, 2026 14:47
7f4f71d to
17195ad
Compare
No flat sibling imports -- the eleven examples are independent -- but the tree kept its pyproject under python/, so it needed the same conversion for one install command to work everywhere. config/ moves inside the package: dex_bimanual_example and full_bimanual_reordering_example resolve it from __file__, so the dex retargeting YAML has to travel with the modules. Six scripts walked up four parents to reach the tree root -- the install prefix for PLUGIN_ROOT_DIR, the checkout for the so101_leader build path. Three levels deeper that lands on the example's python/ directory, so they are parents[5] now. The install tree keeps the same shape, so one depth serves both. Part of #985. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
jiwenc-nv
force-pushed
the
jiwenc-nv/examples-teleop
branch
from
August 28, 2026 16:11
17195ad to
6b41763
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #985. Stacked on #1046.
No flat sibling imports — the eleven examples are independent — but the tree kept its
pyproject.tomlunderpython/, so it needed the same conversion for one install command to work across every example.Two things the move forces, both silent if missed:
config/moves inside the package.dex_bimanual_exampleandfull_bimanual_reordering_exampleresolve it from__file__, so the dex-retargeting YAML has to travel with the modules; the wheel now carries all five files.PLUGIN_ROOT_DIR, the checkout for theso101_leaderbuild path. Three levels deeper that lands on the example's ownpython/directory, so they areparents[5]now. The install tree keeps the same shape, so one depth serves both.This example has the widest reference footprint of the series: five docs pages,
src/plugins/so101_leader/README.md, and a docstring injoint_state_retargeter.py. Runnable commands became-m; prose paths that gained nothing from the full nesting were shortened toexamples/teleop.Type of change
Testing
x86_64/ Ubuntu, Python 3.12. Wheel ships 11 modules and all 5config/files underisaacteleop_examples/teleop/, with no namespace__init__.py.parents[5]verified to land on the repo root.pre-commitclean.Not covered: every example here needs a headset, and several need the
so101_leaderor synthetic-hands plugin. Theparents[5]change is the part worth checking on a real run — a wrong depth shows up as a plugin that cannot be found, not as an import error.Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCONo tests: this is a move with no import changes.