examples(lerobot): package under isaacteleop_examples - #1043
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
45a4b4c to
fcac985
Compare
fcac985 to
ec63e91
Compare
ec63e91 to
45e4ec3
Compare
45e4ec3 to
6098702
Compare
6098702 to
fba88c9
Compare
|
Same as #1038: Needs a root |
fba88c9 to
875ea87
Compare
875ea87 to
b9dffa7
Compare
b9dffa7 to
ee68ef3
Compare
ee68ef3 to
0a3f91a
Compare
No flat sibling imports here -- the three scripts are independent -- but the example had no pyproject.toml, so its dependencies lived in a README line telling you to `pip install lerobot` and nothing declared the rest. Move it to the layout in examples/README.md so it installs and runs like every other example. The dist deliberately does not claim a bare top-level `lerobot`: it would sit in site-packages beside the real one. record.py wrote its dataset next to __file__ while visualize.py and analyze.py read `local_datasets/` from the working directory, so the three only agreed when run from the example directory. record.py now uses the working directory too, which is also the only choice that survives being installed. Part of #985. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
0a3f91a to
77f8958
Compare
Description
Part of #985. Stacked on #1042.
No flat sibling imports here — the three scripts are independent — but the example had no
pyproject.toml, so its dependencies amounted to a README line sayingpip install lerobotwith nothing declaring the rest. This moves it to the layout inexamples/README.mdso it installs and runs like every other example.uv pip install -e ./examples/lerobot # add [viz] for the rerun viewer python -m isaacteleop_examples.lerobot.recordThe dist deliberately does not claim a bare top-level
lerobot— it would land insite-packagesbeside the real one.rerun-sdkis avizextra, since onlyvisualizeneeds it.One inconsistency fixed in passing.
record.pywrote its dataset next to__file__whilevisualize.pyandanalyze.pyreadlocal_datasets/from the working directory — the three only agreed when run from the example directory.record.pynow uses the working directory too, which is also the only choice that survives installation.The README also notes that the SO-101 example the docs reference lives in the LeRobot repo, not here — an easy thing to go looking for in the wrong place.
Type of change
Testing
x86_64/ Ubuntu, Python 3.12. Wheel ships the three modules underisaacteleop_examples/lerobot/with no namespace__init__.py.pre-commitclean.Not covered: recording needs a headset and a
lerobotinstall. No references to this example exist anywhere else in the repo, so the blast radius is the example itself.Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCONo tests: this is a move, and this example has no automated coverage.