Skip to content

examples(haptic_feedback): package under isaacteleop_examples - #1044

Open
jiwenc-nv wants to merge 1 commit into
jiwenc-nv/examples-lerobotfrom
jiwenc-nv/examples-haptic-feedback
Open

examples(haptic_feedback): package under isaacteleop_examples#1044
jiwenc-nv wants to merge 1 commit into
jiwenc-nv/examples-lerobotfrom
jiwenc-nv/examples-haptic-feedback

Conversation

@jiwenc-nv

@jiwenc-nv jiwenc-nv commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Description

Part of #985. Stacked on #1043.

No flat sibling imports here — the two examples are independent — but the tree kept its pyproject.toml under python/ and its README documented uv run <script>.py, so it needed the same conversion as the rest for one install command to work across every example.

uv pip install -e ./examples/haptic_feedback
python -m isaacteleop_examples.haptic_feedback.controller_haptic_example

device/haptic_feedback.rst follows: it pointed at examples/haptic_feedback/python/ and told the reader to run from that directory.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Testing

x86_64 / Ubuntu, Python 3.12. Wheel ships both modules under isaacteleop_examples/haptic_feedback/ with no namespace __init__.py. pre-commit clean.

Not covered: both examples need a controller or a haptic glove plus a running CloudXR/OpenXR runtime.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the linter and formatter with SKIP=check-copyright-year pre-commit run --all-files
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix/feature works (or explained why not)
  • I have signed off all my commits (git commit -s) per the DCO

No tests: this is a move with no import changes at all.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3588d9e2-f6ef-4ca2-bc41-bab05d8a8c1d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-haptic-feedback branch from 6de3608 to 5b6ecc9 Compare August 28, 2026 05:01
@jiwenc-nv
jiwenc-nv changed the base branch from jiwenc-nv/examples-deviceio-live-view to jiwenc-nv/examples-lerobot August 28, 2026 05:02
@jiwenc-nv
jiwenc-nv requested a review from ivany-nv August 28, 2026 05:11
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-haptic-feedback branch from 5b6ecc9 to 98868de Compare August 28, 2026 05:23
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-haptic-feedback branch from 98868de to 6060c4c Compare August 28, 2026 05:32
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-haptic-feedback branch from 6060c4c to e047f6c Compare August 28, 2026 05:44
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-haptic-feedback branch from e047f6c to f362638 Compare August 28, 2026 05:49

@ivany-nv ivany-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff line by line: pure move, no content change to either module.

Verified the install tree lands correctly at the stack tip (pyproject.toml at the example root, no doubled python/python/, no isaacteleop_examples/__init__.py), and python -m isaacteleop_examples.haptic_feedback.controller_haptic_example --help runs from install/examples/haptic_feedback/.

@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-haptic-feedback branch from f362638 to 1a6f010 Compare August 28, 2026 14:46
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-haptic-feedback branch from 1a6f010 to 47d5e7a Compare August 28, 2026 16:11
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-haptic-feedback branch 2 times, most recently from 67c01ac to c92f305 Compare August 29, 2026 00:21
No flat sibling imports here -- the two examples are independent -- but the
tree kept its pyproject under python/ and its README documented `uv run
<script>.py`, so it needed the same conversion as the rest for one install
command to work everywhere. Move it to the layout in examples/README.md.

Part of #985.

Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
@jiwenc-nv
jiwenc-nv force-pushed the jiwenc-nv/examples-haptic-feedback branch from c92f305 to 441c10f Compare August 29, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants