examples(haptic_feedback): package under isaacteleop_examples - #1044
examples(haptic_feedback): package under isaacteleop_examples#1044jiwenc-nv wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
6de3608 to
5b6ecc9
Compare
5b6ecc9 to
98868de
Compare
98868de to
6060c4c
Compare
6060c4c to
e047f6c
Compare
e047f6c to
f362638
Compare
ivany-nv
left a comment
There was a problem hiding this comment.
Read the diff line by line: pure move, no content change to either module.
Verified the install tree lands correctly at the stack tip (pyproject.toml at the example root, no doubled python/python/, no isaacteleop_examples/__init__.py), and python -m isaacteleop_examples.haptic_feedback.controller_haptic_example --help runs from install/examples/haptic_feedback/.
f362638 to
1a6f010
Compare
1a6f010 to
47d5e7a
Compare
67c01ac to
c92f305
Compare
No flat sibling imports here -- the two examples are independent -- but the tree kept its pyproject under python/ and its README documented `uv run <script>.py`, so it needed the same conversion as the rest for one install command to work everywhere. Move it to the layout in examples/README.md. Part of #985. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
c92f305 to
441c10f
Compare
Description
Part of #985. Stacked on #1043.
No flat sibling imports here — the two examples are independent — but the tree kept its
pyproject.tomlunderpython/and its README documenteduv run <script>.py, so it needed the same conversion as the rest for one install command to work across every example.device/haptic_feedback.rstfollows: it pointed atexamples/haptic_feedback/python/and told the reader to run from that directory.Type of change
Testing
x86_64/ Ubuntu, Python 3.12. Wheel ships both modules underisaacteleop_examples/haptic_feedback/with no namespace__init__.py.pre-commitclean.Not covered: both examples need a controller or a haptic glove plus a running CloudXR/OpenXR runtime.
Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCONo tests: this is a move with no import changes at all.