Repository navigation
Remove the Windows installation after uninstall finishes - #832
Merged
SaladDay merged 1 commit intoOct 23, 2026
Merged
Conversation
SaladDay
deleted the
remove-the-windows-installation-after-uninstall-finishes
branch
October 23, 2026 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, uninstall starts a helper that waits about two seconds and then removes
bin(the running executable) and the installation directory. The helper was started before the shared components were released, so when that release took longer than the wait,rmdirran while the executable was still open and left the installation behind. The native onboarding smoke failed this way on PRs #827 and #828 (Uninstall left the installation) and passed on rerun.The helper now starts when
runUninstallreturns, after the release and the final messages.Need help on this PR? Tag
@codesmith-botwith what you need.