Skip to content

Remove the Windows installation after uninstall finishes #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaladDay merged 1 commit into from
Oct 23, 2026
Merged

Remove the Windows installation after uninstall finishes #832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/daemon/internal/cli/native_uninstall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,9 @@ func runUninstall(rc *runContext, args []string) error {
// Only empty directories go; anything left belongs to the user.
_ = os.Remove(filepath.Join(root, "daemon"))
if kept {
// Windows keeps the running executable open until this process exits.
deleteAfterExit(root)
// Windows keeps the running executable open until this process exits;
// the helper starts last so its short wait begins at exit.
defer deleteAfterExit(root)
} else {
_ = os.Remove(root)
}
Expand Down
Loading